aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Keisuke Nishimoto <>
Subject Review Request 62423: Improve in-process test ZooKeeper support
Date Tue, 19 Sep 2017 22:49:31 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for Aurora.

Bugs: AURORA-1947

Repository: aurora


MesosLogStreamModule tries to connect to ZooKeeper servers specified by -zk_endpoints even
when -zk_in_proc=true.  I updated the module to use injected server endpoints which will be
based on the ephemeral port assigned to ZooKeeperTestServer if -zk_in_proc=true.  This required
to make @ServiceDiscoveryBindings.ZooKeeper public.

I also tweaked shutdown process of ServiceDiscoveryModule.TestServerService so that it won't
close existing ZooKeeper connections before clients close the session.  While just delaying
the execution by 1 second doesn't really guarantee that behavior, in practice this achieved
clean shutdown of the scheduler with in-process ZooKeeper server.


  src/main/java/org/apache/aurora/scheduler/discovery/ 28cdc4b3b454b3d25008a21c6b12634173e1f878

  src/main/java/org/apache/aurora/scheduler/discovery/ c105dbdbe8339db7f5cca2e5e391fffb4cd87b07

  src/main/java/org/apache/aurora/scheduler/log/mesos/ 6704a328a4023a178ed8f86ae4772cb04eb2fa8e



1. Launch Mesos master and slave on my laptop.
2. Launch Aurora scheduler with following arguments:
3. Observe that there are no ZooKeeper error log outputs caused by missing endpoint.
4. Create a simple job, observer it launches normally and then kill it.
5. Stop the scheduler by sending /quitquitquit.
6. Observe that scheduler process shuts down normally.


Keisuke Nishimoto

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message