Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============4321458724009165229=="
MIME-Version: 1.0
Subject: Re: Review Request 61918: Fix concurrency issues around banned offers
 in HostOffers
From: Aurora ReviewBot <wfarner@apache.org>
To: Santhosh Kumar Shanmugham <santhoshkumar.s@gmail.com>,
 David McLaughlin <david@dmclaughlin.com>, Stephan Erb <serb@apache.org>,
 Dmitry Zhuk <dzhuk@twopensource.com>
Cc: Aurora <reviews@aurora.apache.org>, Jordan Ly <jordan.ly8@gmail.com>,
 Aurora ReviewBot <wfarner@apache.org>
Date: Wed, 30 Aug 2017 22:16:01 -0000
Message-ID: <20170830221601.20155.784@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Aurora ReviewBot <noreply@reviews.apache.org>
References: <20170830212448.20155.89086@reviews-vm2.apache.org>
In-Reply-To: <20170830212448.20155.89086@reviews-vm2.apache.org>
Reply-To: Aurora ReviewBot <wfarner@apache.org>
archived-at: Wed, 30 Aug 2017 22:16:14 -0000

--===============4321458724009165229==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61918/#review184209
-----------------------------------------------------------


Master (364eac5) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Aug. 30, 2017, 9:24 p.m., Jordan Ly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61918/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2017, 9:24 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Dmitry Zhuk, Santhosh Kumar Shanmugham, and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Currently, `getOffers` and `getWeaklyConsistentOffers` provide iterables that use lambdas (in filter) not backed by concurrent data structures (`globallyBannedOffers` and `staticallyBannedOffers`). This can lead to a race condition where we have unknown behavior if reading and modification happens at the same time.
> 
> To fix this, in `getOffers` we will revert to the previous behavior (before patch https://reviews.apache.org/r/61804/) where we create a copy of the current offers as well as a copy of the banned offers for consistency.
> 
> For `getWeaklyConsistentOffers`, we will use concurrent data structures for `globallyBannedOffers` and `staticallyBannedOffers` so we don't have a race that may produce unknown side effects.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 5697d2e2eb001042511924442ff2dbe358451642 
> 
> 
> Diff: https://reviews.apache.org/r/61918/diff/5/
> 
> 
> Testing
> -------
> 
> Unit tests pass.
> 
> Currently running end to end test and testing on a live cluster.
> 
> 
> Thanks,
> 
> Jordan Ly
> 
>


--===============4321458724009165229==--