Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 821CD200CDA for ; Fri, 4 Aug 2017 18:06:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8086116DCB9; Fri, 4 Aug 2017 16:06:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4695316DCB8 for ; Fri, 4 Aug 2017 18:06:08 +0200 (CEST) Received: (qmail 64299 invoked by uid 500); 4 Aug 2017 16:06:06 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 64280 invoked by uid 99); 4 Aug 2017 16:06:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Aug 2017 16:06:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F3FF81A0AD7; Fri, 4 Aug 2017 16:06:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Bt2H6G8IUZm8; Fri, 4 Aug 2017 16:06:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9169D5FDB5; Fri, 4 Aug 2017 16:06:03 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id ECD04E00A3; Fri, 4 Aug 2017 16:06:02 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 298FDC402BD; Fri, 4 Aug 2017 16:05:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3290691683901939638==" MIME-Version: 1.0 Subject: Re: Review Request 60437: Add timing metrics in MesosCallbackHandler for backward compatibility. From: Stephan Erb To: David McLaughlin , Zameer Manji , Santhosh Kumar Cc: Aurora , Kai Huang Date: Fri, 04 Aug 2017 16:05:59 -0000 Message-ID: <20170804160559.17920.97020@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Stephan Erb X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60437/ X-Sender: Stephan Erb X-ReviewBoard-ShipIt: 1 References: <20170626173725.15286.49699@reviews-vm2.apache.org> In-Reply-To: <20170626173725.15286.49699@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Stephan Erb X-ReviewRequest-Repository: aurora archived-at: Fri, 04 Aug 2017 16:06:09 -0000 --===============3290691683901939638== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60437/#review182215 ----------------------------------------------------------- Ship it! Ship It! - Stephan Erb On June 26, 2017, 7:37 p.m., Kai Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60437/ > ----------------------------------------------------------- > > (Updated June 26, 2017, 7:37 p.m.) > > > Review request for Aurora, David McLaughlin, Santhosh Kumar, and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Add timing metrics in MesosCallbackHandler for backward compatibility. > > We have an internal performance dashboard that reads the following timing metrics: > ``` > scheduler_resource_offers, > scheduler_framework_message, > scheduler_status_update > ``` > Currently, these timing metrics merely reside in MesosSchedulerImpl class. If we were to enable the Mesos HTTP API in aurora(switch from __MesosSchedulerImpl__ to __VersionedMesosSchedulerImpl__), we will lose the timing metrics in MesosSchedulerImpl. This CR migrates the missing timing metrics from MesosSchedulerImpl to MesosCallbackHandler, so that the above timing metrics will be visible after enabling Mesos HTTP API. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java 772a04cbad99eb088105822f41b0758f47f7915a > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java c3a34d2ae51a02247a7e6176dec0f04bddc0270d > src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java b955d61bbed2a6f4cb7f2581ebec398d637f0895 > > > Diff: https://reviews.apache.org/r/60437/diff/1/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Kai Huang > > --===============3290691683901939638==--