aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Ly <>
Subject Re: Review Request 61918: Fix concurrency issues around banned offers in HostOffers
Date Wed, 30 Aug 2017 02:06:31 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 30, 2017, 2:06 a.m.)

Review request for Aurora, David McLaughlin, Dmitry Zhuk, Santhosh Kumar Shanmugham, and Stephan


Added documentation.

Repository: aurora


Currently, `getOffers` and `getWeaklyConsistentOffers` provide iterables that use lambdas
(in filter) not backed by concurrent data structures (`globallyBannedOffers` and `staticallyBannedOffers`).
This can lead to a race condition where we have unknown behavior if reading and modification
happens at the same time.

To fix this, in `getOffers` we will revert to the previous behavior (before patch
where we create a copy of the current offers as well as a copy of the banned offers for consistency.

For `getWeaklyConsistentOffers`, we will use concurrent data structures for `globallyBannedOffers`
and `staticallyBannedOffers` so we don't have a race that may produce unknown side effects.

Diffs (updated)

  src/main/java/org/apache/aurora/scheduler/offers/ 5697d2e2eb001042511924442ff2dbe358451642




Unit tests pass.

Currently running end to end test and testing on a live cluster.


Jordan Ly

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message