Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 95945200CEB for ; Sat, 29 Jul 2017 04:45:30 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9400016C749; Sat, 29 Jul 2017 02:45:30 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D9A4A16C743 for ; Sat, 29 Jul 2017 04:45:29 +0200 (CEST) Received: (qmail 49577 invoked by uid 500); 29 Jul 2017 02:45:28 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 49559 invoked by uid 99); 29 Jul 2017 02:45:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Jul 2017 02:45:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id DBA7AC00A6; Sat, 29 Jul 2017 02:45:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id IvYg3blgtFEY; Sat, 29 Jul 2017 02:45:26 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 70E915FAE1; Sat, 29 Jul 2017 02:45:25 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B8873E00A3; Sat, 29 Jul 2017 02:45:24 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 44167C401D5; Sat, 29 Jul 2017 02:45:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1322926174312508463==" MIME-Version: 1.0 Subject: Re: Review Request 61238: Fix preemption ordering when tasks contain different ResourceTypes From: Aurora ReviewBot To: David McLaughlin , Mauricio Garavaglia Cc: Bill Farner , Aurora , Aurora ReviewBot Date: Sat, 29 Jul 2017 02:45:23 -0000 Message-ID: <20170729024523.64277.96323@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61238/ X-Sender: Aurora ReviewBot X-ReviewBoard-ShipIt: 1 References: <20170729023031.64277.12145@reviews-vm2.apache.org> In-Reply-To: <20170729023031.64277.12145@reviews-vm2.apache.org> Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora archived-at: Sat, 29 Jul 2017 02:45:30 -0000 --===============1322926174312508463== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61238/#review181753 ----------------------------------------------------------- Ship it! Master (cdc5b8e) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On July 29, 2017, 2:30 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61238/ > ----------------------------------------------------------- > > (Updated July 29, 2017, 2:30 a.m.) > > > Review request for Aurora, David McLaughlin and Mauricio Garavaglia. > > > Bugs: AURORA-1943 > https://issues.apache.org/jira/browse/AURORA-1943 > > > Repository: aurora > > > Description > ------- > > Fix preemption ordering when tasks contain different ResourceTypes > > I elected to remove the stream/functional style in the implementation as well. I didn't like the extra iterations it required (3 instead of 1). > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java 5ed578cc4c11b49f607db5f7e516d9e6022a926c > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java c39b00d65c8c2f2f74c836c6117a651fb7f9cd05 > > > Diff: https://reviews.apache.org/r/61238/diff/2/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============1322926174312508463==--