aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 61238: Fix preemption ordering when tasks contain different ResourceTypes
Date Sat, 29 Jul 2017 02:45:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61238/#review181753
-----------------------------------------------------------


Ship it!




Master (cdc5b8e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On July 29, 2017, 2:30 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61238/
> -----------------------------------------------------------
> 
> (Updated July 29, 2017, 2:30 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Mauricio Garavaglia.
> 
> 
> Bugs: AURORA-1943
>     https://issues.apache.org/jira/browse/AURORA-1943
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix preemption ordering when tasks contain different ResourceTypes
> 
> I elected to remove the stream/functional style in the implementation as well.  I didn't
like the extra iterations it required (3 instead of 1).
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java 5ed578cc4c11b49f607db5f7e516d9e6022a926c

>   src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java
c39b00d65c8c2f2f74c836c6117a651fb7f9cd05 
> 
> 
> Diff: https://reviews.apache.org/r/61238/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message