Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E48B0200CAE for ; Wed, 21 Jun 2017 23:27:38 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E3782160BD5; Wed, 21 Jun 2017 21:27:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 31399160BD0 for ; Wed, 21 Jun 2017 23:27:38 +0200 (CEST) Received: (qmail 87906 invoked by uid 500); 21 Jun 2017 21:27:37 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 87895 invoked by uid 99); 21 Jun 2017 21:27:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Jun 2017 21:27:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9E239CEFF4; Wed, 21 Jun 2017 21:27:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.24 X-Spam-Level: *** X-Spam-Status: No, score=3.24 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id p4amXvTf-6HX; Wed, 21 Jun 2017 21:27:35 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D40D95F2EE; Wed, 21 Jun 2017 21:27:34 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2CC32E0069; Wed, 21 Jun 2017 21:27:34 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 1A10FC4034B; Wed, 21 Jun 2017 21:27:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1878735057614272756==" MIME-Version: 1.0 Subject: Re: Review Request 59883: Support specifying a custom ShiroCredentialsMatcher From: Stephan Erb To: "Ruben D. Porras" , Aurora Date: Wed, 21 Jun 2017 21:27:34 -0000 Message-ID: <20170621212734.39411.73120@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Stephan Erb X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59883/ X-Sender: Stephan Erb X-ReviewBoard-ShipIt: 1 References: <20170620204704.1927.87982@reviews-vm2.apache.org> In-Reply-To: <20170620204704.1927.87982@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Stephan Erb X-ReviewRequest-Repository: aurora archived-at: Wed, 21 Jun 2017 21:27:39 -0000 --===============1878735057614272756== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59883/#review178552 ----------------------------------------------------------- Ship it! Ship It! - Stephan Erb On June 20, 2017, 10:47 p.m., Ruben D. Porras wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59883/ > ----------------------------------------------------------- > > (Updated June 20, 2017, 10:47 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > Includes: > - Adding eclipse generated files to .gitignore > - Support specifying a custom ShiroCredentialsMatcher > > > Diffs > ----- > > .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d > src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437 > src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb > > > Diff: https://reviews.apache.org/r/59883/diff/5/ > > > Testing > ------- > > Modify unit tests to add constructor parameter > Run Scheduler manually configured to check that still working properly > > > Thanks, > > Ruben D. Porras > > --===============1878735057614272756==--