Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============3551956255147294111=="
MIME-Version: 1.0
Subject: Re: Review Request 59940: Add a whitelist for TaskStateChange events
 in Webhook.
From: Kai Huang <texasred2013@hotmail.com>
To: Santhosh Kumar Shanmugham <santhoshkumar.s@gmail.com>,
 David McLaughlin <david@dmclaughlin.com>, Stephan Erb <serb@apache.org>,
 Zameer Manji <zmanji@apache.org>
Cc: Aurora ReviewBot <wfarner@apache.org>, Kai Huang <texasred2013@hotmail.com>,
 Aurora <reviews@aurora.apache.org>
Date: Tue, 13 Jun 2017 23:34:56 -0000
Message-ID: <20170613233456.15752.98663@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Kai Huang <noreply@reviews.apache.org>
References: <20170613214044.597.4161@reviews-vm2.apache.org>
In-Reply-To: <20170613214044.597.4161@reviews-vm2.apache.org>
Reply-To: Kai Huang <texasred2013@hotmail.com>
archived-at: Tue, 13 Jun 2017 23:35:02 -0000

--===============3551956255147294111==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59940/
-----------------------------------------------------------

(Updated June 13, 2017, 11:34 p.m.)


Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, Stephan Erb, and Zameer Manji.


Changes
-------

Updated the RELEASE-NOTES for this feature.


Bugs: AURORA-1934
    https://issues.apache.org/jira/browse/AURORA-1934


Repository: aurora


Description
-------

Add a whitelist for TaskStateChange events in Webhook.

Aurora Scheduler has a webhook module that watches all TaskStateChanges and send events to configured endpoint. This will flood the endpoint with a lot of noise if we only care about certain types of TaskStateChange event(e.g. task state change from RUNNING -> LOST). This CR allows user to provide a whitelist of TaskStateChange event types in their webhook configuration file, so that the webhook will only post these events to the configured endpoint.


Diffs (updated)
-----

  RELEASE-NOTES.md c73643d669363a56e530c2d8c79d6ea06cc9415b 
  docs/features/webhooks.md a060975488a50ea34c79aebd66d056df8a3b437e 
  src/main/java/org/apache/aurora/scheduler/events/Webhook.java 3868779986285ac302d028f8713f683192951b83 
  src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java 37c0d7944c7a37e1a5c65dafb290fcdd28765db3 
  src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java e8335d9b78dbf30bf3ae08b6bdd02018cea76f6b 


Diff: https://reviews.apache.org/r/59940/diff/6/

Changes: https://reviews.apache.org/r/59940/diff/5-6/


Testing
-------

./build-support/jenkins/build.sh

This change is backward compatible. By default, all TaskStateChange statuses will be matched and posted to the configured endpoint.

The user can also match all TaskStateChange statuses using a wildcard character "*" in webhook.json like below:
```
{
  "headers": {
    "Content-Type": "application/vnd.kafka.json.v1+json",
    "Producer-Type": "reliable"
  },
  "targetURL": "http://localhost:5000/",
  "timeoutMsec": 50,
  "statuses": ["*"]
}
```

If they are only interested in TaskStateChange statuses: LOST, FAILED, they can provide them in the whitelist:
```
{
  "headers": {
    "Content-Type": "application/vnd.kafka.json.v1+json",
    "Producer-Type": "reliable"
  },
  "targetURL": "http://localhost:5000/",
  "timeoutMsec": 50,
  "statuses": ["LOST", "FAILED"]
}
```


Thanks,

Kai Huang


--===============3551956255147294111==--