Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C64BC200C8F for ; Fri, 9 Jun 2017 10:23:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C4D90160BC8; Fri, 9 Jun 2017 08:23:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 16AFD160B9C for ; Fri, 9 Jun 2017 10:23:22 +0200 (CEST) Received: (qmail 87732 invoked by uid 500); 9 Jun 2017 08:23:22 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 87721 invoked by uid 99); 9 Jun 2017 08:23:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jun 2017 08:23:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5F99BCD346; Fri, 9 Jun 2017 08:23:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.24 X-Spam-Level: *** X-Spam-Status: No, score=3.24 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 0qGLS2bzAOjg; Fri, 9 Jun 2017 08:23:20 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8D82C5FCA4; Fri, 9 Jun 2017 08:23:19 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E6B19E01D8; Fri, 9 Jun 2017 08:23:17 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id C4DA9C400C0; Fri, 9 Jun 2017 08:23:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8925138758236986208==" MIME-Version: 1.0 Subject: Re: Review Request 59883: Includes: - Adding eclipse generated files to .gitignore - Support specifying a custom ShiroCredentialsMatcher From: "Ruben D. Porras" To: "Ruben D. Porras" , Aurora ReviewBot , Aurora , David McLaughlin Date: Fri, 09 Jun 2017 08:23:16 -0000 Message-ID: <20170609082316.1778.91346@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ruben D. Porras" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59883/ X-Sender: "Ruben D. Porras" References: <20170608194851.1778.22518@reviews-vm2.apache.org> In-Reply-To: <20170608194851.1778.22518@reviews-vm2.apache.org> Reply-To: "Ruben D. Porras" X-ReviewRequest-Repository: aurora archived-at: Fri, 09 Jun 2017 08:23:24 -0000 --===============8925138758236986208== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 8, 2017, 9:48 p.m., David McLaughlin wrote: > > Can you give a higher level description of what you're trying to achieve? Allows to use a custom CredentialsMatchers... - using the command line argument **shiro_credentials_matcher** it's possible to specify which credentials matcher class has to be used in order to inject and use it as a credential matcher - in that way, it's possible to use credentials matchers that allows non plain passwords I've tested it implementing a credential matcher for bcrypt, then include the library in the classpath and providing the class with the argument **shiro_credentials_matcher**, so my **shiro.ini** contains bcrypted password. - Ruben D. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59883/#review177359 ----------------------------------------------------------- On June 8, 2017, 9:25 a.m., Ruben D. Porras wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59883/ > ----------------------------------------------------------- > > (Updated June 8, 2017, 9:25 a.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > Includes: > - Adding eclipse generated files to .gitignore > - Support specifying a custom ShiroCredentialsMatcher > > > Diffs > ----- > > .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d > src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437 > src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb > > > Diff: https://reviews.apache.org/r/59883/diff/5/ > > > Testing > ------- > > Modify unit tests to add constructor parameter > Run Scheduler manually configured to check that still working properly > > > Thanks, > > Ruben D. Porras > > --===============8925138758236986208==--