Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E35E5200C88 for ; Fri, 2 Jun 2017 20:54:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E11FE160BD2; Fri, 2 Jun 2017 18:54:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 31DE5160BBA for ; Fri, 2 Jun 2017 20:54:05 +0200 (CEST) Received: (qmail 48293 invoked by uid 500); 2 Jun 2017 18:54:04 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 48269 invoked by uid 99); 2 Jun 2017 18:54:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jun 2017 18:54:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8C9941AF988; Fri, 2 Jun 2017 18:54:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.451 X-Spam-Level: **** X-Spam-Status: No, score=4.451 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Yj9LlFs_fYhI; Fri, 2 Jun 2017 18:54:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 86A775FBE5; Fri, 2 Jun 2017 18:54:00 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EC341E01D9; Fri, 2 Jun 2017 18:53:59 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id BEA62C402E0; Fri, 2 Jun 2017 18:53:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6508739116495195827==" MIME-Version: 1.0 Subject: Re: Review Request 59698: Allow custom OfferManager ordering to be injected via Guice modules From: Santhosh Kumar Shanmugham To: Santhosh Kumar Shanmugham , Stephan Erb Cc: Aurora , David McLaughlin Date: Fri, 02 Jun 2017 18:53:59 -0000 Message-ID: <20170602185359.16397.37563@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Santhosh Kumar Shanmugham X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59698/ X-Sender: Santhosh Kumar Shanmugham X-ReviewBoard-ShipIt: 1 References: <20170601001422.8718.90190@reviews-vm2.apache.org> In-Reply-To: <20170601001422.8718.90190@reviews-vm2.apache.org> Reply-To: Santhosh Kumar Shanmugham X-ReviewRequest-Repository: aurora archived-at: Fri, 02 Jun 2017 18:54:06 -0000 --===============6508739116495195827== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59698/#review176826 ----------------------------------------------------------- Ship it! LGTM. (My guice knowledge is limited.) - Santhosh Kumar Shanmugham On May 31, 2017, 5:14 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59698/ > ----------------------------------------------------------- > > (Updated May 31, 2017, 5:14 p.m.) > > > Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > Given how powerful a global ordering of offers is, it's worth allowing custom orderings to be injected with a CLI-provided Guice module. This is consistent with the other custom scheduling logic work. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 96acaf9ab7479c818a1f89e0faa33aad971bb5d4 > src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java ee80176e81a997a1361c036c9fbda6d120109a27 > src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java e999ac5faee98333e69e964073000a2a9481d081 > > > Diff: https://reviews.apache.org/r/59698/diff/1/ > > > Testing > ------- > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > David McLaughlin > > --===============6508739116495195827==--