Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D039E200CA9 for ; Fri, 2 Jun 2017 01:48:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CE9EC160BDF; Thu, 1 Jun 2017 23:48:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1FD90160BC4 for ; Fri, 2 Jun 2017 01:48:06 +0200 (CEST) Received: (qmail 82041 invoked by uid 500); 1 Jun 2017 23:48:06 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 82025 invoked by uid 99); 1 Jun 2017 23:48:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Jun 2017 23:48:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id AFE71CA9F0; Thu, 1 Jun 2017 23:48:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.702 X-Spam-Level: **** X-Spam-Status: No, score=4.702 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id pRFReKr_XzN8; Thu, 1 Jun 2017 23:48:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E79895FC7F; Thu, 1 Jun 2017 23:48:02 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4875CE0280; Thu, 1 Jun 2017 23:48:02 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 337FFC404B8; Thu, 1 Jun 2017 23:48:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7957854528404836832==" MIME-Version: 1.0 Subject: Review Request 59733: Adding Configurable Wait Period for Graceful Shutdowns From: Jordan Ly To: Santhosh Kumar Shanmugham , David McLaughlin , Stephan Erb , Zameer Manji Cc: Aurora , Jordan Ly Date: Thu, 01 Jun 2017 23:48:02 -0000 Message-ID: <20170601234802.34605.69330@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jordan Ly X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59733/ X-Sender: Jordan Ly Reply-To: Jordan Ly X-ReviewRequest-Repository: aurora archived-at: Thu, 01 Jun 2017 23:48:08 -0000 --===============7957854528404836832== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59733/ ----------------------------------------------------------- Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, Stephan Erb, and Zameer Manji. Bugs: AURORA-1931 https://issues.apache.org/jira/browse/AURORA-1931 Repository: aurora Description ------- We have some services that require more than the current 10 seconds given to gracefully shutdown (they need to close resources, finish requests, etc). We would like to be able to configure the amount of time we wait between each stage of the graceful shutdown sequence. See this [proposal](https://docs.google.com/document/d/1Sl-KWNyt1j0nIndinqfJsH3pkUY5IYXfGWyLHU2wacs/edit?usp=sharing) for a more in-depth analysis. Diffs ----- src/main/python/apache/aurora/config/schema/base.py b2692a648645a195a24491e4978fb833c6c20be8 src/main/python/apache/aurora/executor/aurora_executor.py 81461cb49ac223f3bdfa59e8c59e150a07771dea src/main/python/apache/aurora/executor/http_lifecycle.py 9280bf29da9bda1691adbf3a4c34c4f3d4900517 src/test/python/apache/aurora/client/cli/test_inspect.py 4a23c5984c2d093e2f53e93aec71418f84b65928 src/test/python/apache/aurora/executor/test_http_lifecycle.py a967e3410a4d2dc2e1721f505a4d76da9209d177 src/test/python/apache/aurora/executor/test_thermos_task_runner.py 1b92667bceabc8ea1540122477a51cb58ea2ae36 Diff: https://reviews.apache.org/r/59733/diff/1/ Testing ------- Ran unit and integration tests. Created and killed jobs with varying wait_escalation_secs values on the Vagrant devcluster. Thanks, Jordan Ly --===============7957854528404836832==--