aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 60212: Instruct Thermos executor to detect taskfs when inside a Mesos container
Date Fri, 23 Jun 2017 19:47:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60212/#review178807
-----------------------------------------------------------



Master (a922b05) is red with this patch.
  ./build-support/jenkins/build.sh

+ popd
/home/jenkins/jenkins-slave/workspace/AuroraBot
+ exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-15.0.2/virtualenv.py
--no-download /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv
New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7
Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python
Installing setuptools, pip, wheel...done.
Collecting isort==4.0.0
  Downloading isort-4.0.0-py2.py3-none-any.whl
Installing collected packages: isort
Successfully installed isort-4.0.0
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/test_sandbox.py
Imports are incorrectly sorted.
--- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/test_sandbox.py:before
2017-06-23 19:41:05.645112
+++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/test_sandbox.py:after
2017-06-23 19:47:34.754213
@@ -30,15 +30,15 @@
 
 from gen.apache.aurora.api.constants import TASK_FILESYSTEM_MOUNT_POINT
 from gen.apache.aurora.api.ttypes import (
-  AssignedTask,
-  Container,
-  DockerContainer,
-  DockerImage,
-  Image,
-  MesosContainer,
-  JobKey,
-  TaskConfig,
-  Volume,
+    AssignedTask,
+    Container,
+    DockerContainer,
+    DockerImage,
+    Image,
+    JobKey,
+    MesosContainer,
+    TaskConfig,
+    Volume
 )
 
 


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On June 23, 2017, 7:07 p.m., Jason Lai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60212/
> -----------------------------------------------------------
> 
> (Updated June 23, 2017, 7:07 p.m.)
> 
> 
> Review request for Aurora, Eric Chung, Joshua Cohen, Dmitriy Shirchenko, Stephan Erb,
and Zameer Manji.
> 
> 
> Bugs: AURORA-1903
>     https://issues.apache.org/jira/browse/AURORA-1903
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Instruct Thermos executor to detect the `taskfs` volume when running inside a Mesos container.
If taskfs is not enabled, use `DockerDirectorySandbox` instead of `FileSystemImageSandbox`
for sandbox bootstrapping.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/sandbox.py fe1562eeb5a149b540ec2e080ee0b677105bf20e

>   src/test/python/apache/aurora/executor/common/test_sandbox.py 0b4958a5645d356135fe6ca6364b8343bfb2cf44

> 
> 
> Diff: https://reviews.apache.org/r/60212/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Lai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message