aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Lai <ja...@jasonlai.net>
Subject Re: Review Request 60208: Add Thrift schema for POSIX RLimit support for Mesos containers
Date Tue, 20 Jun 2017 21:45:43 GMT


> On June 20, 2017, 7:35 p.m., Stephan Erb wrote:
> > We will still need to store new new fields, plumb them through, and maybe even add
them to the client DSL (optional). Do you plan to cover those in separate patch?

Yes indeed. I have created a bunch some subtasks for them, but the store part and DSL subtasks
are yet to create. I'll do them soon.


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60208/#review178418
-----------------------------------------------------------


On June 19, 2017, 9:04 p.m., Jason Lai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60208/
> -----------------------------------------------------------
> 
> (Updated June 19, 2017, 9:04 p.m.)
> 
> 
> Review request for Aurora, Eric Chung, Joshua Cohen, Charles Raimbert, and Zameer Manji.
> 
> 
> Bugs: AURORA-1936
>     https://issues.apache.org/jira/browse/AURORA-1936
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add Thrift schema for POSIX RLimit support for Mesos containers
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad

> 
> 
> Diff: https://reviews.apache.org/r/60208/diff/1/
> 
> 
> Testing
> -------
> 
> Make sure the Aurora Thrift schema is structurally equivalent to the [RLimitInfo](https://github.com/apache/mesos/blob/1.2.x/include/mesos/mesos.proto#L2295-L2333)
ProtoBuf schema introduced in Mesos 1.2.x.
> 
> 
> Thanks,
> 
> Jason Lai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message