aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Chung <cinchu...@gmail.com>
Subject Re: Review Request 60208: Add Thrift schema for POSIX RLimit support for Mesos containers
Date Mon, 19 Jun 2017 21:45:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60208/#review178311
-----------------------------------------------------------




api/src/main/thrift/org/apache/aurora/gen/api.thrift
Line 202 (original), 202 (patched)
<https://reviews.apache.org/r/60208/#comment252197>

    Maybe add a reference in the comments so people will know where this came from?


- Eric Chung


On June 19, 2017, 9:04 p.m., Jason Lai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60208/
> -----------------------------------------------------------
> 
> (Updated June 19, 2017, 9:04 p.m.)
> 
> 
> Review request for Aurora, Eric Chung, Joshua Cohen, Charles Raimbert, and Zameer Manji.
> 
> 
> Bugs: AURORA-1936
>     https://issues.apache.org/jira/browse/AURORA-1936
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add Thrift schema for POSIX RLimit support for Mesos containers
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad

> 
> 
> Diff: https://reviews.apache.org/r/60208/diff/1/
> 
> 
> Testing
> -------
> 
> Make sure the Aurora Thrift schema is structurally equivalent to the [RLimitInfo](https://github.com/apache/mesos/blob/1.2.x/include/mesos/mesos.proto#L2295-L2333)
ProtoBuf schema introduced in Mesos 1.2.x.
> 
> 
> Thanks,
> 
> Jason Lai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message