aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Ly <jordan....@gmail.com>
Subject Re: Review Request 60173: Allow custom Thrift method interceptors to be injected via Guice modules
Date Mon, 19 Jun 2017 17:12:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60173/
-----------------------------------------------------------

(Updated June 19, 2017, 5:12 p.m.)


Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, Stephan Erb, and Zameer
Manji.


Changes
-------

Removed unused import.


Repository: aurora


Description
-------

Allow for custom Thrift method interceptors to be injected via Guice modules. Cluster operators
might use this feature to inject interceptors that only allow certain roles to call certain
endpoints, or to dynamically check if a job should be able to use a constraint.


Diffs (updated)
-----

  RELEASE-NOTES.md e032f7927a68b00401ea8f073ff52b5def74f3ce 
  docs/reference/scheduler-configuration.md 3d53c5a552e06f62a7572591fb0c92ccae42c54b 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java f59ee1a0514a6dc52573c0b932cba755e0a10e18



Diff: https://reviews.apache.org/r/60173/diff/2/

Changes: https://reviews.apache.org/r/60173/diff/1-2/


Testing
-------

Injected a custom module on a Vagrant box.

Unit + integration tests pass.


Thanks,

Jordan Ly


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message