aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 60133: Update h2 to 1.4.196
Date Thu, 15 Jun 2017 22:16:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60133/#review178057
-----------------------------------------------------------


Ship it!




Ship It!

- Zameer Manji


On June 15, 2017, 3:13 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60133/
> -----------------------------------------------------------
> 
> (Updated June 15, 2017, 3:13 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This update picks up my H2 patch improving SLF4j logging performance (https://github.com/h2database/h2database/commit/e907049a2b4a18ef3ab47bb0779e60005722bcb7).
> 
> Additional changes in this release: http://www.h2database.com/html/changelog.html
> 
> The UpdateStore performance seems to have improved by roughly a factor of three. The
snapshot benchmarks are currently broken (and I failed to fix them). I assume they might show
an improvement as well.
> 
> Before:
> UpdateStoreBenchmarks.JobDetailsBenchmark.run                         N/A         1000
        N/A  thrpt    5  119.038 ± 54.139  ops/s
> UpdateStoreBenchmarks.JobDetailsBenchmark.run                         N/A         5000
        N/A  thrpt    5   37.694 ±  3.426  ops/s
> UpdateStoreBenchmarks.JobDetailsBenchmark.run                         N/A        10000
        N/A  thrpt    5   18.649 ±  3.810  ops/s
> UpdateStoreBenchmarks.JobInstructionsBenchmark.run                      1          N/A
        N/A  thrpt    5   37.918 ±  6.921  ops/s
> UpdateStoreBenchmarks.JobInstructionsBenchmark.run                     10          N/A
        N/A  thrpt    5   37.762 ±  5.814  ops/s
> UpdateStoreBenchmarks.JobInstructionsBenchmark.run                    100          N/A
        N/A  thrpt    5   30.227 ± 18.007  ops/s
> UpdateStoreBenchmarks.JobInstructionsBenchmark.run                   1000          N/A
        N/A  thrpt    5   15.769 ± 14.883  ops/s
> UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run                  N/A          N/A
         10  thrpt    5   33.075 ± 17.729  ops/s
> UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run                  N/A          N/A
        100  thrpt    5   35.692 ± 11.266  ops/s
> UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run                  N/A          N/A
       1000  thrpt    5   26.050 ± 12.683  ops/s
> UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run                  N/A          N/A
      10000  thrpt    5    9.561 ± 13.355  ops/s
> 
> After:
> UpdateStoreBenchmarks.JobDetailsBenchmark.run                         N/A         1000
        N/A  thrpt    5  414.317 ± 232.301  ops/s
> UpdateStoreBenchmarks.JobDetailsBenchmark.run                         N/A         5000
        N/A  thrpt    5  112.781 ±  41.688  ops/s
> UpdateStoreBenchmarks.JobDetailsBenchmark.run                         N/A        10000
        N/A  thrpt    5   57.149 ±  30.002  ops/s
> UpdateStoreBenchmarks.JobInstructionsBenchmark.run                      1          N/A
        N/A  thrpt    5  114.242 ±  54.799  ops/s
> UpdateStoreBenchmarks.JobInstructionsBenchmark.run                     10          N/A
        N/A  thrpt    5  118.942 ±  17.132  ops/s
> UpdateStoreBenchmarks.JobInstructionsBenchmark.run                    100          N/A
        N/A  thrpt    5  103.792 ±  17.981  ops/s
> UpdateStoreBenchmarks.JobInstructionsBenchmark.run                   1000          N/A
        N/A  thrpt    5   46.515 ±   7.201  ops/s
> UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run                  N/A          N/A
         10  thrpt    5  114.828 ±  35.298  ops/s
> UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run                  N/A          N/A
        100  thrpt    5  112.394 ±  42.421  ops/s
> UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run                  N/A          N/A
       1000  thrpt    5   83.514 ±  52.970  ops/s
> UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run                  N/A          N/A
      10000  thrpt    5   32.203 ±  15.586  ops/s
> 
> 
> Diffs
> -----
> 
>   build.gradle 4802d5e552b978338b037326eae85e193a7eb2d1 
> 
> 
> Diff: https://reviews.apache.org/r/60133/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message