aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 59957: Remove restriction on task id length.
Date Fri, 09 Jun 2017 23:24:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59957/#review177525
-----------------------------------------------------------


Ship it!




Master (6dc3d37) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On June 9, 2017, 10:14 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59957/
> -----------------------------------------------------------
> 
> (Updated June 9, 2017, 10:14 p.m.)
> 
> 
> Review request for Aurora and Santhosh Kumar Shanmugham.
> 
> 
> Bugs: AURORA-1897
>     https://issues.apache.org/jira/browse/AURORA-1897
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> To work around an old Mesos bug (MESOS-691) we would reject jobs that resulted in Mesos
task ids longer than 255 characters. This is because Mesos used to use the task id to generate
the cgroup path. Now Mesos uses it's own id, we no longer need to work around this bug.
> 
> This removes the restriction in the API layer. This is useful because some users may
have very long role and service names that caused task ids to go over this limit.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 059fbb86a575f5b3d78a63c9a7b5a9eebb6cb3ae

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
016859ca3bf83f64d2576b4c7109729770f9e25c 
> 
> 
> Diff: https://reviews.apache.org/r/59957/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message