aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Ly <jordan....@gmail.com>
Subject Re: Review Request 59733: Adding Configurable Wait Period for Graceful Shutdowns
Date Fri, 09 Jun 2017 19:02:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59733/#review177506
-----------------------------------------------------------



After some testing, I believe it would be better to expose two config fields instead of one,
allowing the user to set timeouts for each of the shutdown endpoints independently.
It will be something like `graceful_shutdown_timeout_secs` and `shutdown_timeout_secs`. This
will give greater control over the termination cycle and make it easier
to understand the configurations.

I will update this ticket in a few days with the changes. Please do not merge yet :)

- Jordan Ly


On June 7, 2017, 1:06 a.m., Jordan Ly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59733/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 1:06 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, Stephan Erb,
and Zameer Manji.
> 
> 
> Bugs: AURORA-1931
>     https://issues.apache.org/jira/browse/AURORA-1931
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We have some services that require more than the current 10 seconds given to 
> gracefully shutdown (they need to close resources, finish requests, etc).
> 
> We would like to be able to configure the amount of time we wait between each
> stage of the graceful shutdown sequence. See this [proposal](https://docs.google.com/document/d/1Sl-KWNyt1j0nIndinqfJsH3pkUY5IYXfGWyLHU2wacs/edit?usp=sharing)
for a more in-depth
> analysis.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md c73643d669363a56e530c2d8c79d6ea06cc9415b 
>   docs/reference/configuration.md 0040de17a85f5820c069474716678c66afce373b 
>   docs/reference/task-lifecycle.md cf1b6794dca92756cee4a54f00f33fd3b1a481ea 
>   src/main/python/apache/aurora/config/schema/base.py b2692a648645a195a24491e4978fb833c6c20be8

>   src/main/python/apache/aurora/executor/aurora_executor.py 81461cb49ac223f3bdfa59e8c59e150a07771dea

>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c6c08983fb2d204afedd419798135d667169bce4

>   src/main/python/apache/aurora/executor/http_lifecycle.py 9280bf29da9bda1691adbf3a4c34c4f3d4900517

>   src/test/python/apache/aurora/client/cli/test_inspect.py 4a23c5984c2d093e2f53e93aec71418f84b65928

>   src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py 38deae69dce7d88dab87f70e0128e0b86091fdef

>   src/test/python/apache/aurora/executor/test_http_lifecycle.py a967e3410a4d2dc2e1721f505a4d76da9209d177

>   src/test/python/apache/aurora/executor/test_thermos_executor.py e628ccd21f0588d0c76001b8f336ffa844c3ec35

>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 1b92667bceabc8ea1540122477a51cb58ea2ae36

> 
> 
> Diff: https://reviews.apache.org/r/59733/diff/4/
> 
> 
> Testing
> -------
> 
> Ran unit and integration tests.
> 
> Created and killed jobs with varying wait_escalation_secs values on the Vagrant devcluster.
> 
> 
> Thanks,
> 
> Jordan Ly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message