aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reza Motamedi <reza.motam...@gmail.com>
Subject Re: Review Request 59864: Allow disk monitoring to be disabled in Thermos Executor
Date Wed, 07 Jun 2017 22:24:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59864/
-----------------------------------------------------------

(Updated June 7, 2017, 10:24 p.m.)


Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and Stephan Erb.


Repository: aurora


Description
-------

# Allow disk monitoring to be disabled in Thermos Executor

related tickets:
- https://issues.apache.org/jira/browse/AURORA-1033
- https://issues.apache.org/jira/browse/AURORA-1918

https://docs.google.com/document/d/1-1eYenw9wgsWXyyOWn32l0oJBBXpzIN5V20vi0AZpi8/edit?usp=sharing

This RB is related to part(1) of the above document. As I learned recently, the community
favors disabling the disk monitoring in the Observer as well, and this would be addressed
in part(2). I think it is possible to keep the current bahavior by asking the Mesos Agent,
but for sure disabling the monitoring is the easiest way.


Diffs (updated)
-----

  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c6c08983fb2d204afedd419798135d667169bce4

  src/main/python/apache/aurora/executor/common/resource_manager.py b7dc40d8973ec2e5998ab4f6ff988051a70bb1ab

  src/main/python/apache/thermos/monitoring/disk.py 52c5d74fd70b5942ea3ef5101ba3f27bfc98fc21



Diff: https://reviews.apache.org/r/59864/diff/2/

Changes: https://reviews.apache.org/r/59864/diff/1-2/


Testing
-------

I tested this by running `./build-support/jenkins/build.sh` and it passed.

I also modified 
`-thermos_executor_flags="--announcer-ensemble localhost:2181 --announcer-zookeeper-auth-config
/home/vagrant/aurora/examples/vagrant/config/announcer-auth.json --mesos-containerizer-path=/u
   sr/libexec/mesos/mesos-containerizer"`
to
`-thermos_executor_flags="--announcer-ensemble localhost:2181 --announcer-zookeeper-auth-config
/home/vagrant/aurora/examples/vagrant/config/announcer-auth.json --mesos-containerizer-path=/u
   sr/libexec/mesos/mesos-containerizer --disable-disk-monitor"`
in `examples/vagrant/upstart/aurora-scheduler.conf` and the falg is being picked up and the
task is executed.


Thanks,

Reza Motamedi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message