aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 59883: Includes: - Adding eclipse generated files to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Date Wed, 07 Jun 2017 16:20:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review177176
-----------------------------------------------------------



Master (73234d0) is red with this patch.
  ./build-support/jenkins/build.sh

:assemble
:compileJmhJava
Download https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-core/1.15/jmh-core-1.15.pom
Download https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-parent/1.15/jmh-parent-1.15.pom
Download https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-generator-annprocess/1.15/jmh-generator-annprocess-1.15.pom
Download https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-core/1.15/jmh-core-1.15.jar
Download https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-generator-annprocess/1.15/jmh-generator-annprocess-1.15.jar
Download https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-annotations/2.5.1/jackson-annotations-2.5.1.pom
Download https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-annotations/2.5.1/jackson-annotations-2.5.1.jar
Note: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
Download https://repo1.maven.org/maven2/com/puppycrawl/tools/checkstyle/7.3/checkstyle-7.3.pom
Download https://repo1.maven.org/maven2/com/puppycrawl/tools/checkstyle/7.3/checkstyle-7.3.jar
:jsHint
:checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:25:
Wrong order for 'com.google.common.annotations.VisibleForTesting' import. Order should be:
java, javax, scala, com, net, org.         Each group should be separated by a single blank
line. [ImportOrder]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:46:
'help' have incorrect indentation level 4, expected level should be 6. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:46:1:
Line contains a tab character. [FileTabCharacter]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:47:
Line has trailing spaces. [RegexpSingleline]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:48:3:
Line contains a tab character. [FileTabCharacter]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:54:
Line has trailing spaces. [RegexpSingleline]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:82:
Line has trailing spaces. [RegexpSingleline]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:88:39:
'ini' hides a field. [HiddenField]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:92:
Line has trailing spaces. [RegexpSingleline]
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to
get more log output.

BUILD FAILED

Total time: 2 mins 50.248 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On June 7, 2017, 5:54 p.m., Ruben D. Porras wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 5:54 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Includes: 
> - Adding eclipse generated files to .gitignore 
> - Support specifying a custom ShiroCredentialsMatcher
> 
> 
> Diffs
> -----
> 
>   .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
43c38dcffd8e68c018217681cc5a3073d9fb1437 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb

> 
> 
> Diff: https://reviews.apache.org/r/59883/diff/1/
> 
> 
> Testing
> -------
> 
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
> 
> 
> Thanks,
> 
> Ruben D. Porras
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message