aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David McLaughlin <da...@dmclaughlin.com>
Subject Re: Review Request 59698: Allow custom OfferManager ordering to be injected via Guice modules
Date Thu, 01 Jun 2017 21:18:45 GMT


> On June 1, 2017, 9:15 p.m., Reza Motamedi wrote:
> > src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java
> > Lines 121-123 (patched)
> > <https://reviews.apache.org/r/59698/diff/1/?file=1736083#file1736083line121>
> >
> >     So, these installed modules are just needed by the private-module, right?

Normally you're right and you would limit the exposure of the binding, but here it's outside
of the PrivateModule for the OfferSettings.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59698/#review176660
-----------------------------------------------------------


On June 1, 2017, 12:14 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59698/
> -----------------------------------------------------------
> 
> (Updated June 1, 2017, 12:14 a.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Given how powerful a global ordering of offers is, it's worth allowing custom orderings
to be injected with a CLI-provided Guice module. This is consistent with the other custom
scheduling logic work.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 96acaf9ab7479c818a1f89e0faa33aad971bb5d4

>   src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java ee80176e81a997a1361c036c9fbda6d120109a27

>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java e999ac5faee98333e69e964073000a2a9481d081

> 
> 
> Diff: https://reviews.apache.org/r/59698/diff/1/
> 
> 
> Testing
> -------
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message