aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David McLaughlin <da...@dmclaughlin.com>
Subject Review Request 59698: Allow custom OfferManager ordering to be injected via Guice modules
Date Thu, 01 Jun 2017 00:14:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59698/
-----------------------------------------------------------

Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb.


Repository: aurora


Description
-------

Given how powerful a global ordering of offers is, it's worth allowing custom orderings to
be injected with a CLI-provided Guice module. This is consistent with the other custom scheduling
logic work.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 96acaf9ab7479c818a1f89e0faa33aad971bb5d4

  src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java ee80176e81a997a1361c036c9fbda6d120109a27

  src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java e999ac5faee98333e69e964073000a2a9481d081



Diff: https://reviews.apache.org/r/59698/diff/1/


Testing
-------

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

David McLaughlin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message