Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============0189171506280079635=="
MIME-Version: 1.0
Subject: Re: Review Request 59640: Prioritize adding instances over updating
 instances during an update
From: Santhosh Kumar Shanmugham <santhoshkumar.s@gmail.com>
To: Santhosh Kumar Shanmugham <santhoshkumar.s@gmail.com>,
 David McLaughlin <david@dmclaughlin.com>, Stephan Erb <serb@apache.org>,
 Zameer Manji <zmanji@apache.org>
Cc: Aurora <reviews@aurora.apache.org>, Jordan Ly <jordan.ly8@gmail.com>
Date: Wed, 31 May 2017 20:04:29 -0000
Message-ID: <20170531200429.8717.50768@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Santhosh Kumar Shanmugham <noreply@reviews.apache.org>
References: <20170530212113.1818.17150@reviews-vm2.apache.org>
In-Reply-To: <20170530212113.1818.17150@reviews-vm2.apache.org>
Reply-To: Santhosh Kumar Shanmugham <santhoshkumar.s@gmail.com>
archived-at: Wed, 31 May 2017 20:04:34 -0000

--===============0189171506280079635==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59640/#review176507
-----------------------------------------------------------


LGTM. Minor comments.


src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java
Lines 163 (patched)
<https://reviews.apache.org/r/59640/#comment249890>

    private class?
    
    Do we really need this class to be `Serializable`?


src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java
Lines 193 (patched)
<https://reviews.apache.org/r/59640/#comment249891>

    avoid `this`?


src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java
Lines 201-204 (patched)
<https://reviews.apache.org/r/59640/#comment249892>

    This seems extra defensive.


- Santhosh Kumar Shanmugham


On May 30, 2017, 2:21 p.m., Jordan Ly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59640/
> -----------------------------------------------------------
> 
> (Updated May 30, 2017, 2:21 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1928
>     https://issues.apache.org/jira/browse/AURORA-1928
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Currently, when updating a job we choose to update instances naively by ascending instance ID number.
> However, it would be better to add new instances before killing and updating older instances.
> 
> This patch makes it so the job updater prefers to create new instances, then
> update instances, and finally kill instances.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 14c2d2de3186271819a5f4e527d3b30fd34d2b21 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 290385d737294e23e9dd50f2631303124aa7af7c 
>   src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java 611f6b8681c8e0b286cd361bdb5ace1fea39d9a5 
> 
> 
> Diff: https://reviews.apache.org/r/59640/diff/1/
> 
> 
> Testing
> -------
> 
> Ran unit tests and integration tests.
> 
> Had to modify some integration tests since we now prefer to create over update -- needed to change
> the ordering of actions. Additionally, some unit tests only specified configs for one instance even
> though desiredInstances is always 2 -- had to make it so the range of configurations is always 0-2
> when creating. Otherwise, it would try to create instances first even though the test didn't really
> care.
> 
> Tested different update configurations on the Vagrant cluster: only adding instances, only updating
> instances, only killing instances, create & update, update & kill.
> 
> 
> Thanks,
> 
> Jordan Ly
> 
>


--===============0189171506280079635==--