Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 180D9200C7F for ; Wed, 24 May 2017 23:05:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 169DC160BB6; Wed, 24 May 2017 21:05:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5DBDD160BA5 for ; Wed, 24 May 2017 23:05:47 +0200 (CEST) Received: (qmail 16482 invoked by uid 500); 24 May 2017 21:05:46 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 16471 invoked by uid 99); 24 May 2017 21:05:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 May 2017 21:05:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D82871AFDAE; Wed, 24 May 2017 21:05:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id cYa9W7tD57iS; Wed, 24 May 2017 21:05:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id ED9DB5F19B; Wed, 24 May 2017 21:05:43 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 51D7FE02AA; Wed, 24 May 2017 21:05:43 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 45AABC402E3; Wed, 24 May 2017 21:05:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0120571185272716753==" MIME-Version: 1.0 Subject: Re: Review Request 59539: Add cluster state debug endpoint to Scheduler HTTP servlet From: Aurora ReviewBot To: Santhosh Kumar Shanmugham , Stephan Erb , Zameer Manji Cc: Aurora , David McLaughlin , Aurora ReviewBot Date: Wed, 24 May 2017 21:05:43 -0000 Message-ID: <20170524210543.61833.12553@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59539/ X-Sender: Aurora ReviewBot X-ReviewBoard-ShipIt: 1 References: <20170524205146.61834.9290@reviews-vm2.apache.org> In-Reply-To: <20170524205146.61834.9290@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/http/State.java X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/http/StateTest.java Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora archived-at: Wed, 24 May 2017 21:05:48 -0000 --===============0120571185272716753== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59539/#review175997 ----------------------------------------------------------- Ship it! Master (767563e) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On May 24, 2017, 8:51 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59539/ > ----------------------------------------------------------- > > (Updated May 24, 2017, 8:51 p.m.) > > > Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > The struct exposed here is the one used to make preemption decisions - it has the entire state of running tasks. It's a very handy summary structure to analyse the state of the current scheduling results. Exposing it here to make it easier to do analysis on our test clusters (currently have to process backups). > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 53ebc0b60e60a8e1800f9e8b4ddc292bb44b4330 > src/main/java/org/apache/aurora/scheduler/http/State.java PRE-CREATION > src/main/resources/scheduler/assets/index.html 9bd22a8d5b1aebe7e19ebfd1077fb36f82ea6c36 > src/test/java/org/apache/aurora/scheduler/http/StateTest.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/59539/diff/2/ > > > Testing > ------- > > Tests pass. Also ran in vagrant. > > > Thanks, > > David McLaughlin > > --===============0120571185272716753==--