Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5832C200C78 for ; Thu, 18 May 2017 19:25:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 56AAD160BB5; Thu, 18 May 2017 17:25:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 753B4160B9D for ; Thu, 18 May 2017 19:25:26 +0200 (CEST) Received: (qmail 5150 invoked by uid 500); 18 May 2017 17:25:25 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 5138 invoked by uid 99); 18 May 2017 17:25:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 May 2017 17:25:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EAA6CC061B; Thu, 18 May 2017 17:25:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.249 X-Spam-Level: **** X-Spam-Status: No, score=4.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, MANY_SPAN_IN_TEXT=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id p-xj2B9fYTPQ; Thu, 18 May 2017 17:25:22 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 73AC95FB96; Thu, 18 May 2017 17:25:22 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0B638E015A; Thu, 18 May 2017 17:25:22 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D78F8C40019; Thu, 18 May 2017 17:25:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7155633259281252181==" MIME-Version: 1.0 Subject: Re: Review Request 59163: Added 'aurora task scp' command for copying to task instances From: Aurora ReviewBot To: David McLaughlin , Reza Motamedi , Santhosh Kumar Cc: Aurora , Jordan Ly , Aurora ReviewBot Date: Thu, 18 May 2017 17:25:21 -0000 Message-ID: <20170518172521.63780.82508@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59163/ X-Sender: Aurora ReviewBot X-ReviewBoard-ShipIt: 1 References: <20170518061230.55001.2219@reviews-vm2.apache.org> In-Reply-To: <20170518061230.55001.2219@reviews-vm2.apache.org> Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora archived-at: Thu, 18 May 2017 17:25:27 -0000 --===============7155633259281252181== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59163/#review175405 ----------------------------------------------------------- Ship it! Master (b00a15e) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On May 18, 2017, 6:12 a.m., Jordan Ly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59163/ > ----------------------------------------------------------- > > (Updated May 18, 2017, 6:12 a.m.) > > > Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar. > > > Bugs: AURORA-1925 > https://issues.apache.org/jira/browse/AURORA-1925 > > > Repository: aurora > > > Description > ------- > > Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance. > > This command essentially mimics scp but expands task instances into their respective user@host:path > For 'aurora task scp' the sandbox is the relative root. However, you can still use absolute paths and use > '~' to access the role's home directory. > > Example usage: > From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:` > From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:test.txt .` > From task tmp folder to host: `aurora task scp cluster/role/env/job/instance:/tmp/test.txt .` > From one task to another task: `aurora task scp cluster/role/env/job/instance:test.txt cluster/role/env/job/instance:some/dir/` > > > Diffs > ----- > > RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07 > docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5 > src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2 > src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2 > src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0 > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca > > > Diff: https://reviews.apache.org/r/59163/diff/7/ > > > Testing > ------- > > `./pants test src/test/python/apache/aurora/client/cli:cli` > ``` > 23:07:10 00:03 [run] > ============== test session starts =============== > platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4 > plugins: cov, timeout > collected 179 items > > src/test/python/apache/aurora/client/cli/test_config_noun.py ... > src/test/python/apache/aurora/client/cli/test_context.py ........ > src/test/python/apache/aurora/client/cli/test_version.py . > src/test/python/apache/aurora/client/cli/test_quota.py ..... > src/test/python/apache/aurora/client/cli/test_plugins.py . > src/test/python/apache/aurora/client/cli/test_client.py .. > src/test/python/apache/aurora/client/cli/test_sla.py ..... > src/test/python/apache/aurora/client/cli/test_open.py ..... > src/test/python/apache/aurora/client/cli/test_supdate.py ....................................... > src/test/python/apache/aurora/client/cli/test_restart.py .......... > src/test/python/apache/aurora/client/cli/test_status.py ............. > src/test/python/apache/aurora/client/cli/test_add.py .... > src/test/python/apache/aurora/client/cli/test_diff.py .. > src/test/python/apache/aurora/client/cli/test_cron.py .......... > src/test/python/apache/aurora/client/cli/test_command_hooks.py .. > src/test/python/apache/aurora/client/cli/test_options.py ...... > src/test/python/apache/aurora/client/cli/test_task.py ............... > src/test/python/apache/aurora/client/cli/test_create.py .............. > src/test/python/apache/aurora/client/cli/test_kill.py ...................... > src/test/python/apache/aurora/client/cli/test_inspect.py .... > src/test/python/apache/aurora/client/cli/test_api_from_cli.py .. > src/test/python/apache/aurora/client/cli/test_diff_formatter.py ...... > > ========== 179 passed in 24.88 seconds =========== > > 23:07:37 00:30 [complete] > SUCCESS > ``` > > I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created. > > > Thanks, > > Jordan Ly > > --===============7155633259281252181==--