aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santhosh Kumar Shanmugham <santhoshkuma...@gmail.com>
Subject Re: Review Request 59565: Normalize state endpoint.
Date Thu, 25 May 2017 16:35:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59565/#review176092
-----------------------------------------------------------


Ship it!




LGTM. Some naming suggestions to make it easier to understand.


src/main/java/org/apache/aurora/scheduler/http/State.java
Lines 50 (patched)
<https://reviews.apache.org/r/59565/#comment249421>

    Call this `taskConfigLookupId` or `taskConfigId`? Calling it `taskId` starts colliding
with the existing concept of taskIds.



src/main/java/org/apache/aurora/scheduler/http/State.java
Lines 64 (patched)
<https://reviews.apache.org/r/59565/#comment249423>

    Call this `taskConfigs`?



src/test/java/org/apache/aurora/scheduler/http/StateTest.java
Lines 76-78 (patched)
<https://reviews.apache.org/r/59565/#comment249416>

    Probably call them `taskConfig1`, `taskConfig2`, `taskConfig3`?



src/test/java/org/apache/aurora/scheduler/http/StateTest.java
Lines 79-81 (patched)
<https://reviews.apache.org/r/59565/#comment249422>

    Call these `taskConfigLookupId1` or `taskConfigId1` so on?


- Santhosh Kumar Shanmugham


On May 24, 2017, 7:43 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59565/
> -----------------------------------------------------------
> 
> (Updated May 24, 2017, 7:43 p.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The state endpoint was over 400MB in our scale test environment (!!). This shrinks it
down to 14MB.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/State.java dc356b77206d81bce7c8172248f08cd9fb8d7f30

>   src/test/java/org/apache/aurora/scheduler/http/StateTest.java 0af8b0d79a4d80276b4bf5bedfe26d3c076c40d8

> 
> 
> Diff: https://reviews.apache.org/r/59565/diff/1/
> 
> 
> Testing
> -------
> 
> $ ls -al
> -rw-r--r--   1 dmclaughlin  440799949 May 24 15:15 aurora-state.json
> -rw-r--r--   1 dmclaughlin   14636611 May 24 19:35 aurora-state-normalized.json
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message