aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 59417: Bump logback to 1.2.3 and SLF4J to 1.7.25
Date Fri, 19 May 2017 20:55:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59417/#review175571
-----------------------------------------------------------


Ship it!




Master (4c0974b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On May 19, 2017, 8:33 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59417/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 8:33 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The changelog entries that stand out the most:
> 
> * The ReentrantLock in OutputStreamAppender is now "unfair". In previous
>   versions of logback, a fair lock was used. Fair locks are much slower.
>   Just as importanly, logback has no mandate to influence thread scheduling.
> * In PatternLayoutBase the same StringBuilder is used over and over to
>   reduce memory allocation.
> 
> I am unable to observe any improvements in our micro-benchmarks. In any
> case, I still think it is worth to stay up to date.
> 
> Full changelogs:
> 
> * https://www.slf4j.org/news.html
> * https://logback.qos.ch/news.html
> 
> 
> Diffs
> -----
> 
>   build.gradle b7a4f059b6de8acca882f3cd1e881434f4befbfa 
> 
> 
> Diff: https://reviews.apache.org/r/59417/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message