aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Ly <jordan....@gmail.com>
Subject Re: Review Request 59163: Added 'aurora task scp' command for copying to task instances
Date Thu, 18 May 2017 06:12:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/
-----------------------------------------------------------

(Updated May 18, 2017, 6:12 a.m.)


Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.


Changes
-------

Removed ability to do tilde expansion that was added in the previous review request.


Bugs: AURORA-1925
    https://issues.apache.org/jira/browse/AURORA-1925


Repository: aurora


Description
-------

Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.

This command essentially mimics scp but expands task instances into their respective user@host:path
For 'aurora task scp' the sandbox is the relative root. However, you can still use absolute
paths and use 
'~' to access the role's home directory.

Example usage:
>From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:`
>From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:test.txt
.`
>From task tmp folder to host: `aurora task scp cluster/role/env/job/instance:/tmp/test.txt
.`
>From one task to another task: `aurora task scp cluster/role/env/job/instance:test.txt
cluster/role/env/job/instance:some/dir/`


Diffs (updated)
-----

  RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07 
  docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5 
  src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2

  src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2

  src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0

  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca



Diff: https://reviews.apache.org/r/59163/diff/6/

Changes: https://reviews.apache.org/r/59163/diff/5-6/


Testing (updated)
-------

`./pants test src/test/python/apache/aurora/client/cli:cli`
```
23:07:10 00:03       [run]
                     ============== test session starts ===============
                     platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
                     plugins: cov, timeout
                     collected 179 items

                     src/test/python/apache/aurora/client/cli/test_config_noun.py ...
                     src/test/python/apache/aurora/client/cli/test_context.py ........
                     src/test/python/apache/aurora/client/cli/test_version.py .
                     src/test/python/apache/aurora/client/cli/test_quota.py .....
                     src/test/python/apache/aurora/client/cli/test_plugins.py .
                     src/test/python/apache/aurora/client/cli/test_client.py ..
                     src/test/python/apache/aurora/client/cli/test_sla.py .....
                     src/test/python/apache/aurora/client/cli/test_open.py .....
                     src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
                     src/test/python/apache/aurora/client/cli/test_restart.py ..........
                     src/test/python/apache/aurora/client/cli/test_status.py .............
                     src/test/python/apache/aurora/client/cli/test_add.py ....
                     src/test/python/apache/aurora/client/cli/test_diff.py ..
                     src/test/python/apache/aurora/client/cli/test_cron.py ..........
                     src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
                     src/test/python/apache/aurora/client/cli/test_options.py ......
                     src/test/python/apache/aurora/client/cli/test_task.py ...............
                     src/test/python/apache/aurora/client/cli/test_create.py ..............
                     src/test/python/apache/aurora/client/cli/test_kill.py ......................
                     src/test/python/apache/aurora/client/cli/test_inspect.py ....
                     src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
                     src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......

                     ========== 179 passed in 24.88 seconds ===========

23:07:37 00:30   [complete]
               SUCCESS
```

I've also compiled it within the local cluster with Vagrant and used the command to transfer
a text file between the scheduler machine and job I created.


Thanks,

Jordan Ly


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message