aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santhosh Kumar Shanmugham <santhoshkuma...@gmail.com>
Subject Re: Review Request 59231: fix update affinity cache name
Date Fri, 12 May 2017 16:50:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59231/#review174816
-----------------------------------------------------------


Ship it!




Ship It!

- Santhosh Kumar Shanmugham


On May 12, 2017, 9:48 a.m., Reza Motamedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59231/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 9:48 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham,
and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> fix update affinity cache name
> 
> in a previous review (https://reviews.apache.org/r/58636/) I introduced metrics for BiCache
explicit removals and expirations. There I changed the contract to instead of passing _cache
size metric name_, I require just the __cache name__. That has already up applied to all usages
of Bichae. The update affinitiy patch had a merge conflict that did not pick this change,
which leads to metric names such as `update_affinity_cache_size_cache_expiration_removals`,
 `update_affinity_cache_size_cache_explicit_removals`, `update_affinity_cache_size_cache_removals`,
`update_affinity_cache_size_cache_size`.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 219bb4e2ae1111e61336a6779531288d066f3ea7

> 
> 
> Diff: https://reviews.apache.org/r/59231/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Reza Motamedi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message