aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 58922: Make sure we track scheduling penalty when no tasks are scheduled.
Date Tue, 02 May 2017 17:23:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58922/#review173609
-----------------------------------------------------------



Master (f1e2537) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On May 2, 2017, 5:22 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58922/
> -----------------------------------------------------------
> 
> (Updated May 2, 2017, 5:22 p.m.)
> 
> 
> Review request for Aurora, Mehrdad Nurolahzade, Reza Motamedi, Santhosh Kumar Shanmugham,
and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make sure we track scheduling penalty when no tasks are scheduled.
> 
> Note on change: discovered testing https://reviews.apache.org/r/58259/. We were not accumulating
the penalty when no tasks in a batch were scheduled (which is a common case for preemption
candidates and update batches that are waiting on reservations).
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java cea8d0f0795acfd3bbe2f1ee120ec047eee34e0f

> 
> 
> Diff: https://reviews.apache.org/r/58922/diff/2/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message