Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============6100946301578957561=="
MIME-Version: 1.0
Subject: Re: Review Request 58768: AURORA-1924 Aurora client should reconcile
 idempotent job creations
From: Mehrdad Nurolahzade <mehrdad@apache.org>
To: David McLaughlin <david@dmclaughlin.com>, Stephan Erb <serb@apache.org>,
 Zameer Manji <zmanji@apache.org>
Cc: Aurora <reviews@aurora.apache.org>,
 Mehrdad Nurolahzade <mehrdad@apache.org>
Date: Thu, 27 Apr 2017 00:04:09 -0000
Message-ID: <20170427000409.64641.30364@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Mehrdad Nurolahzade <noreply@reviews.apache.org>
References: <20170426235703.64641.97672@reviews-vm2.apache.org>
In-Reply-To: <20170426235703.64641.97672@reviews-vm2.apache.org>
Reply-To: Mehrdad Nurolahzade <mehrdad@apache.org>
archived-at: Thu, 27 Apr 2017 00:04:14 -0000

--===============6100946301578957561==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58768/#review173134
-----------------------------------------------------------


api/src/main/thrift/org/apache/aurora/gen/api.thrift
Lines 960-962 (patched)
<https://reviews.apache.org/r/58768/#comment246219>

    Personally, I don't like the obsecure contract that I have introduced here using this superflous struct.
    
    Should we rather introduce a new `ResponseCode` for idempotency?


- Mehrdad Nurolahzade


On April 26, 2017, 4:57 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58768/
> -----------------------------------------------------------
> 
> (Updated April 26, 2017, 4:57 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1924
>     https://issues.apache.org/jira/browse/AURORA-1924
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Aurora scheduler rejects a request to create a job if a job with the same key already exists. Aurora client exits with an error once it receives a response with `ResponseCode.INVALID_REQUEST` from scheduler in this case.
> 
> However, an attempt to create a job with the exact same configuration and number of instances is essentially idempotent. Scheduler can detect this situation, ignore it, and signal client to treat operation as successful; client warns user about existing job but does not fail the operation.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 059fbb86a575f5b3d78a63c9a7b5a9eebb6cb3ae 
>   src/main/python/apache/aurora/client/cli/jobs.py b79ae56bee0e5692cacf1e66f4a4126b06aaffdc 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 016859ca3bf83f64d2576b4c7109729770f9e25c 
>   src/test/python/apache/aurora/client/cli/test_create.py 3b09bb25e919bac2795ccd56bd98657b1f98690b 
> 
> 
> Diff: https://reviews.apache.org/r/58768/diff/1/
> 
> 
> Testing
> -------
> 
> - Manually under Vagrant
> - End to end test script
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>


--===============6100946301578957561==--