Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4304B200C61 for ; Tue, 25 Apr 2017 16:56:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 415E9160BB3; Tue, 25 Apr 2017 14:56:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 62078160B9E for ; Tue, 25 Apr 2017 16:56:42 +0200 (CEST) Received: (qmail 95066 invoked by uid 500); 25 Apr 2017 14:56:41 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 95055 invoked by uid 99); 25 Apr 2017 14:56:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Apr 2017 14:56:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DBD661B09E8; Tue, 25 Apr 2017 14:56:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.251 X-Spam-Level: *** X-Spam-Status: No, score=3.251 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id U5jmXfTMeFYa; Tue, 25 Apr 2017 14:56:38 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6A6265FCC9; Tue, 25 Apr 2017 14:56:38 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 10499E017A; Tue, 25 Apr 2017 14:56:38 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id BFC14C4029A; Tue, 25 Apr 2017 14:56:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8134392464387052419==" MIME-Version: 1.0 Subject: Re: Review Request 58636: adding metrics for removals from bicache From: David McLaughlin To: David McLaughlin , Mehrdad Nurolahzade , Santhosh Kumar Cc: Aurora , Reza Motamedi Date: Tue, 25 Apr 2017 14:56:37 -0000 Message-ID: <20170425145637.17468.59271@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: David McLaughlin X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58636/ X-Sender: David McLaughlin X-ReviewBoard-ShipIt: 1 References: <20170424230845.17468.54824@reviews-vm2.apache.org> In-Reply-To: <20170424230845.17468.54824@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: David McLaughlin X-ReviewRequest-Repository: aurora archived-at: Tue, 25 Apr 2017 14:56:43 -0000 --===============8134392464387052419== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58636/#review172930 ----------------------------------------------------------- Ship it! Ship It! - David McLaughlin On April 24, 2017, 11:08 p.m., Reza Motamedi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58636/ > ----------------------------------------------------------- > > (Updated April 24, 2017, 11:08 p.m.) > > > Review request for Aurora, David McLaughlin, Mehrdad Nurolahzade, and Santhosh Kumar. > > > Repository: aurora > > > Description > ------- > > - adding metrics for removals from bicache > > I updated this patch according to the nicer implementaion on an older RB from @mehrdad: https://reviews.apache.org/r/55027. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/preemptor/BiCache.java 70390f6b1ead322ebe3dd5d625dad44b70e2d185 > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 66d20290d381c041ac2f28903d6ba1468b352172 > src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 03a0e8485d1a392f107fda5b4af05b7f8f6067c6 > src/test/java/org/apache/aurora/scheduler/preemptor/BiCacheTest.java bac8f3348fd7f369a60f6a492fa2d996e4c47b44 > src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java 4da4e9da2053631228e612fd7f06ca7013f3ac24 > > > Diff: https://reviews.apache.org/r/58636/diff/3/ > > > Testing > ------- > > ``` > # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:bicache-metrics ? [16:22:23] > ? ./build-support/jenkins/build.sh > > . > .. > ... > > Executing tasks in goals: setup-py > 16:22:16 00:00 [setup-py] > 16:22:16 00:00 [setup-py] > Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/kerberos/BUILD, FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), kerberos)) > Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/common/BUILD, FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), common)) > Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(api/src/main/thrift/org/apache/aurora/gen/BUILD, FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), gen)) > Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/admin/BUILD, FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), admin)) > Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/client/BUILD, FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), client)) > Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/config/BUILD, FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), config)) > Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/thermos/config/BUILD, FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), config)) > Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/thermos/common/BUILD, FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), common)) > Creating setup.py project for PythonThriftLibrary(BuildFileAddress(BuildFile(api/src/main/thrift/org/apache/thermos/BUILD, FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), thermos)) > Running packager against /Users/rmotamedi/oss/aurora/dist/apache.thermos.thrift-0.18.0-SNAPSHOT > Writing /Users/rmotamedi/oss/aurora/dist/apache.thermos.thrift-0.18.0-SNAPSHOT.tar.gz > Running packager against /Users/rmotamedi/oss/aurora/dist/apache.aurora.thrift-0.18.0-SNAPSHOT > Writing /Users/rmotamedi/oss/aurora/dist/apache.aurora.thrift-0.18.0-SNAPSHOT.tar.gz > Running packager against /Users/rmotamedi/oss/aurora/dist/apache.thermos.common-0.18.0-SNAPSHOT > Writing /Users/rmotamedi/oss/aurora/dist/apache.thermos.common-0.18.0-SNAPSHOT.tar.gz > Running packager against /Users/rmotamedi/oss/aurora/dist/apache.thermos.config-0.18.0-SNAPSHOT > Writing /Users/rmotamedi/oss/aurora/dist/apache.thermos.config-0.18.0-SNAPSHOT.tar.gz > Running packager against /Users/rmotamedi/oss/aurora/dist/apache.aurora.common-0.18.0-SNAPSHOT > Writing /Users/rmotamedi/oss/aurora/dist/apache.aurora.common-0.18.0-SNAPSHOT.tar.gz > Running packager against /Users/rmotamedi/oss/aurora/dist/apache.aurora.config-0.18.0-SNAPSHOT > Writing /Users/rmotamedi/oss/aurora/dist/apache.aurora.config-0.18.0-SNAPSHOT.tar.gz > Running packager against /Users/rmotamedi/oss/aurora/dist/apache.aurora.client-0.18.0-SNAPSHOT > Writing /Users/rmotamedi/oss/aurora/dist/apache.aurora.client-0.18.0-SNAPSHOT.tar.gz > Running packager against /Users/rmotamedi/oss/aurora/dist/apache.aurora.admin-0.18.0-SNAPSHOT > Writing /Users/rmotamedi/oss/aurora/dist/apache.aurora.admin-0.18.0-SNAPSHOT.tar.gz > Running packager against /Users/rmotamedi/oss/aurora/dist/apache.aurora.kerberos-0.18.0-SNAPSHOT > Writing /Users/rmotamedi/oss/aurora/dist/apache.aurora.kerberos-0.18.0-SNAPSHOT.tar.gz > 16:22:23 00:07 [complete] > SUCCESS > ``` > > > Thanks, > > Reza Motamedi > > --===============8134392464387052419==--