Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 89B39200C5F for ; Sun, 23 Apr 2017 13:15:47 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8836A160BA6; Sun, 23 Apr 2017 11:15:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CF120160B8E for ; Sun, 23 Apr 2017 13:15:46 +0200 (CEST) Received: (qmail 96570 invoked by uid 500); 23 Apr 2017 11:15:46 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 96559 invoked by uid 99); 23 Apr 2017 11:15:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Apr 2017 11:15:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6B4DCC0E29 for ; Sun, 23 Apr 2017 11:15:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id FuS1nj7CofPa for ; Sun, 23 Apr 2017 11:15:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 26FDA5F482 for ; Sun, 23 Apr 2017 11:15:44 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C42C9E02A9; Sun, 23 Apr 2017 11:15:43 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B3B85C40099; Sun, 23 Apr 2017 11:15:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4542359965683679044==" MIME-Version: 1.0 Subject: Re: Review Request 58611: Bump initial_task_kill_retry_interval to 15s. From: Stephan Erb To: Zameer Manji Cc: Aurora Date: Sun, 23 Apr 2017 11:15:43 -0000 Message-ID: <20170423111543.1862.22662@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Stephan Erb X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58611/ X-Sender: Stephan Erb References: <20170421103609.22346.50324@reviews-vm2.apache.org> In-Reply-To: <20170421103609.22346.50324@reviews-vm2.apache.org> Reply-To: Stephan Erb X-ReviewRequest-Repository: aurora archived-at: Sun, 23 Apr 2017 11:15:47 -0000 --===============4542359965683679044== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58611/#review172748 ----------------------------------------------------------- @ReviewBot retry - Stephan Erb On April 21, 2017, 12:36 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58611/ > ----------------------------------------------------------- > > (Updated April 21, 2017, 12:36 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > It is not very common that kills are dropped by Mesos and have to be retried > by Aurora. It therefore makes sense to slightly increase the retry timeout > so that we don't retry needlessly when Thermos is still busy executing > the lifecycle methods. > > By default, Thermos uses the following kill escalation sequence: > > * /quitquitquit > * wait 5s > * /abortabortabort > * wait 5s > * SIGTERM > * wait up to 1 minute > * SIGKILL > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java e076e802f8920b37cef202520c7fbe59724dd06d > > > Diff: https://reviews.apache.org/r/58611/diff/1/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > > --===============4542359965683679044==--