Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 46D6E200C4E for ; Fri, 21 Apr 2017 18:44:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 459B5160B86; Fri, 21 Apr 2017 16:44:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8AD33160B97 for ; Fri, 21 Apr 2017 18:44:25 +0200 (CEST) Received: (qmail 11106 invoked by uid 500); 21 Apr 2017 16:44:15 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 8489 invoked by uid 99); 21 Apr 2017 16:44:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Apr 2017 16:44:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D3889C22F5 for ; Fri, 21 Apr 2017 16:44:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id JHH9sFfEyYGJ for ; Fri, 21 Apr 2017 16:44:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 36DEC5F342 for ; Fri, 21 Apr 2017 16:44:08 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CB2AEE0041; Fri, 21 Apr 2017 16:44:07 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A6529C400D6; Fri, 21 Apr 2017 16:44:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3291917625531981556==" MIME-Version: 1.0 Subject: Re: Review Request 58609: Switch Thermos runner to simple disk log layout From: Aurora ReviewBot To: Joshua Cohen , Zameer Manji Cc: Aurora ReviewBot , Stephan Erb , Aurora Date: Fri, 21 Apr 2017 16:44:07 -0000 Message-ID: <20170421164407.23980.3175@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58609/ X-Sender: Aurora ReviewBot References: <20170421093501.24123.74645@reviews-vm2.apache.org> In-Reply-To: <20170421093501.24123.74645@reviews-vm2.apache.org> Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora archived-at: Fri, 21 Apr 2017 16:44:26 -0000 --===============3291917625531981556== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58609/#review172675 ----------------------------------------------------------- Master (b847db8) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 21, 2017, 9:35 a.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58609/ > ----------------------------------------------------------- > > (Updated April 21, 2017, 9:35 a.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Switch Thermos runner to simple disk log layout. > > This collapses the individual files per loglevel. We will therefore have just one log file for executor and one for the runner. > > -- > > Not to reviwers: I am unsure why the executor log file defaults to __main__ rather than the name of the binary. I decided not to dig deeper here, as it is not my main problem during operations. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/thermos_task_runner.py 8f88af4c24ddc603fa12587741af56a6c711e420 > > > Diff: https://reviews.apache.org/r/58609/diff/1/ > > > Testing > ------- > > ./pants test.pytest src/test/python:: > > > File Attachments > ---------------- > > after.png > https://reviews.apache.org/media/uploaded/files/2017/04/21/8816f094-b473-45bd-8d9a-fd2f3fad7dfe__after.png > before.png > https://reviews.apache.org/media/uploaded/files/2017/04/21/f10b3500-a66b-4850-a571-f964b97b7b40__before.png > > > Thanks, > > Stephan Erb > > --===============3291917625531981556==--