Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 26FF5200C4E for ; Fri, 21 Apr 2017 14:50:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 254C0160BA2; Fri, 21 Apr 2017 12:50:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 45EF1160B97 for ; Fri, 21 Apr 2017 14:50:21 +0200 (CEST) Received: (qmail 72150 invoked by uid 500); 21 Apr 2017 12:50:20 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 72128 invoked by uid 99); 21 Apr 2017 12:50:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Apr 2017 12:50:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CCEC01AFB99 for ; Fri, 21 Apr 2017 12:50:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id iZ_TLYGeQ76A for ; Fri, 21 Apr 2017 12:50:17 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0215F60DA5 for ; Fri, 21 Apr 2017 12:50:17 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 56979E0041; Fri, 21 Apr 2017 12:50:16 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 47911C402C9; Fri, 21 Apr 2017 12:50:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1258906520273314299==" MIME-Version: 1.0 Subject: Re: Review Request 58611: Bump initial_task_kill_retry_interval to 15s. From: Aurora ReviewBot To: Zameer Manji Cc: Aurora ReviewBot , Stephan Erb , Aurora Date: Fri, 21 Apr 2017 12:50:16 -0000 Message-ID: <20170421125016.24123.49782@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58611/ X-Sender: Aurora ReviewBot References: <20170421103609.22346.50324@reviews-vm2.apache.org> In-Reply-To: <20170421103609.22346.50324@reviews-vm2.apache.org> Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora archived-at: Fri, 21 Apr 2017 12:50:22 -0000 --===============1258906520273314299== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58611/#review172647 ----------------------------------------------------------- Master (b847db8) is red with this patch. ./build-support/jenkins/build.sh Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$2 Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$1 Test coverage missing for org/apache/aurora/scheduler/HostOffer Test coverage missing for org/apache/aurora/scheduler/TaskVars Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$SchedulerCandidateImpl Test coverage missing for org/apache/aurora/scheduler/BatchWorker$Work Test coverage missing for org/apache/aurora/scheduler/TierInfo Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter Test coverage missing for org/apache/aurora/scheduler/TaskVars$1 Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$TaskEventBatchWorker Test coverage missing for org/apache/aurora/scheduler/BatchWorker Test coverage missing for org/apache/aurora/scheduler/HostOffer$1 Test coverage missing for org/apache/aurora/scheduler/SchedulerModule Test coverage missing for org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$1 Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl Test coverage missing for org/apache/aurora/scheduler/SchedulerServicesModule Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl$1 Test coverage missing for org/apache/aurora/scheduler/TierModule Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/ScheduleStatusTypeHandler Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/JobUpdateStatusTypeHandler Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/MaintenanceModeTypeHandler Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/CronCollisionPolicyTypeHandler Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/AbstractTEnumTypeHandler Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/JobUpdateActionTypeHandler Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/ResourceTypeHandler * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. ============================================================================== BUILD FAILED Total time: 5 mins 59.083 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 21, 2017, 10:36 a.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58611/ > ----------------------------------------------------------- > > (Updated April 21, 2017, 10:36 a.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > It is not very common that kills are dropped by Mesos and have to be retried > by Aurora. It therefore makes sense to slightly increase the retry timeout > so that we don't retry needlessly when Thermos is still busy executing > the lifecycle methods. > > By default, Thermos uses the following kill escalation sequence: > > * /quitquitquit > * wait 5s > * /abortabortabort > * wait 5s > * SIGTERM > * wait up to 1 minute > * SIGKILL > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java e076e802f8920b37cef202520c7fbe59724dd06d > > > Diff: https://reviews.apache.org/r/58611/diff/1/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > > --===============1258906520273314299==--