Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5FF02200C6A for ; Wed, 19 Apr 2017 11:53:51 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5E9A0160B94; Wed, 19 Apr 2017 09:53:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A5A77160B86 for ; Wed, 19 Apr 2017 11:53:50 +0200 (CEST) Received: (qmail 10286 invoked by uid 500); 19 Apr 2017 09:53:48 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 10031 invoked by uid 99); 19 Apr 2017 09:53:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Apr 2017 09:53:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DBAC0CD48B; Wed, 19 Apr 2017 09:53:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id vy874GuE6TaY; Wed, 19 Apr 2017 09:53:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id ACEBC60D83; Wed, 19 Apr 2017 09:53:46 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4CA9FE00A6; Wed, 19 Apr 2017 09:53:46 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 08D8EC40387; Wed, 19 Apr 2017 09:53:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3078280865229341280==" MIME-Version: 1.0 Subject: Re: Review Request 58524: Allow task to be in STARTING state during watch_secs. From: Aurora ReviewBot To: Joshua Cohen , Stephan Erb , Zameer Manji Cc: Santhosh Kumar Shanmugham , Aurora , Aurora ReviewBot Date: Wed, 19 Apr 2017 09:53:45 -0000 Message-ID: <20170419095345.30063.51726@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58524/ X-Sender: Aurora ReviewBot X-ReviewBoard-ShipIt: 1 References: <20170419090744.34543.47885@reviews-vm2.apache.org> In-Reply-To: <20170419090744.34543.47885@reviews-vm2.apache.org> Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora archived-at: Wed, 19 Apr 2017 09:53:51 -0000 --===============3078280865229341280== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58524/#review172333 ----------------------------------------------------------- Ship it! Master (b847db8) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 19, 2017, 9:07 a.m., Santhosh Kumar Shanmugham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58524/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 9:07 a.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Tasks are gated on health-checks before they transistion into `RUNNING` > and hence it is possible for a task to stay in `STARTING` during the > watch duration of an instance's update. So include `STARTING` into the > possible states for a task when watching it after an update. Without > this tasks will wait for watch_secs after the task moves to RUNNING > extending the update time. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java c129896d8cd54abd2634e2a339c27921042b0162 > src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java c95943d242dc2f539778bdc9e071f342005e8de3 > src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java df1f8394b824dbb7b2745fcccdab5adaafdf6e6c > src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java 32a8c89d3e71395696fc613da96b871330891c42 > > > Diff: https://reviews.apache.org/r/58524/diff/1/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Santhosh Kumar Shanmugham > > --===============3078280865229341280==--