Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============3834898792327663987=="
MIME-Version: 1.0
Subject: Re: Review Request 58462: Fix bug. Do not increase
 current_consecutive_successes if .healthchecksnooze present
From: Santhosh Kumar Shanmugham <santhoshkumar.s@gmail.com>
To: Joshua Cohen <jcohen@apache.org>, Zameer Manji <zmanji@apache.org>
Cc: Santhosh Kumar Shanmugham <santhoshkumar.s@gmail.com>,
 Aurora <reviews@aurora.apache.org>, Vladimir Khalatyan <vkhalatyan@gmail.com>
Date: Fri, 14 Apr 2017 21:26:34 -0000
Message-ID: <20170414212634.20123.59752@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Santhosh Kumar Shanmugham <noreply@reviews.apache.org>
References: <20170414203534.20122.10529@reviews-vm2.apache.org>
In-Reply-To: <20170414203534.20122.10529@reviews-vm2.apache.org>
Reply-To: Santhosh Kumar Shanmugham <santhoshkumar.s@gmail.com>
archived-at: Fri, 14 Apr 2017 21:26:39 -0000

--===============3834898792327663987==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58462/#review172032
-----------------------------------------------------------


src/main/python/apache/aurora/executor/common/health_checker.py
Lines 163-166 (patched)
<https://reviews.apache.org/r/58462/#comment245092>

    This will cause a task to get stuck in `STARTING` since `self.running` will never be set to `True`.
    
    Can you explain the particular usecase here? Also add a test case to exercise this branch.


- Santhosh Kumar Shanmugham


On April 14, 2017, 1:35 p.m., Vladimir Khalatyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58462/
> -----------------------------------------------------------
> 
> (Updated April 14, 2017, 1:35 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix bug. Do not increase current_consecutive_successes if .healthchecksnooze present
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py e9e4129af2db5202a82e9f6d54109a00bbae97ce 
> 
> 
> Diff: https://reviews.apache.org/r/58462/diff/1/
> 
> 
> Testing
> -------
> 
> The Health Check is succeeding when the .healthchecksnooze is present. But it should just snooze which means there shouldn't be any increase in consecutive successes or consecutive failures.
> 
> 
> Thanks,
> 
> Vladimir Khalatyan
> 
>


--===============3834898792327663987==--