aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santhosh Kumar Shanmugham <santhoshkuma...@gmail.com>
Subject Re: Review Request 58636: adding metrics for removals from bicache
Date Mon, 24 Apr 2017 20:15:29 GMT


> On April 21, 2017, 9:38 p.m., Mehrdad Nurolahzade wrote:
> > src/main/java/org/apache/aurora/scheduler/preemptor/BiCache.java
> > Lines 86 (patched)
> > <https://reviews.apache.org/r/58636/diff/1/?file=1697673#file1697673line86>
> >
> >     You can also get eviction stats. I took a stab at this a while back but that
RB never got shipped cause I did not figure what was wrong with one of the broken test files.

> >     
> >     See https://reviews.apache.org/r/55027/diff/2#1
> 
> Stephan Erb wrote:
>     So we accept this RB and discard the one you have just linked?
> 
> David McLaughlin wrote:
>     Seems like Mehrdad's solution is cleaner for tracking expirations.
> 
> Mehrdad Nurolahzade wrote:
>     I discarded the other RB in favor of this one.

+1 for the approach in the previous patch. Can we bring it back?


- Santhosh Kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58636/#review172730
-----------------------------------------------------------


On April 21, 2017, 4:34 p.m., Reza Motamedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58636/
> -----------------------------------------------------------
> 
> (Updated April 21, 2017, 4:34 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Mehrdad Nurolahzade, and Santhosh Kumar.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> adding metrics for removals from bicache
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/preemptor/BiCache.java 70390f6b1ead322ebe3dd5d625dad44b70e2d185

>   src/test/java/org/apache/aurora/scheduler/preemptor/BiCacheTest.java bac8f3348fd7f369a60f6a492fa2d996e4c47b44

> 
> 
> Diff: https://reviews.apache.org/r/58636/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:bicache-metrics ? [16:22:23]
> ? ./build-support/jenkins/build.sh
> 
> .
> ..
> ...
> 
>                Executing tasks in goals: setup-py
> 16:22:16 00:00   [setup-py]
> 16:22:16 00:00     [setup-py]
>                    Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/kerberos/BUILD,
FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), kerberos))
>                    Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/common/BUILD,
FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), common))
>                    Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(api/src/main/thrift/org/apache/aurora/gen/BUILD,
FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), gen))
>                    Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/admin/BUILD,
FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), admin))
>                    Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/client/BUILD,
FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), client))
>                    Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/config/BUILD,
FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), config))
>                    Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/thermos/config/BUILD,
FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), config))
>                    Creating setup.py project for PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/thermos/common/BUILD,
FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), common))
>                    Creating setup.py project for PythonThriftLibrary(BuildFileAddress(BuildFile(api/src/main/thrift/org/apache/thermos/BUILD,
FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), thermos))
>                    Running packager against /Users/rmotamedi/oss/aurora/dist/apache.thermos.thrift-0.18.0-SNAPSHOT
>                    Writing /Users/rmotamedi/oss/aurora/dist/apache.thermos.thrift-0.18.0-SNAPSHOT.tar.gz
>                    Running packager against /Users/rmotamedi/oss/aurora/dist/apache.aurora.thrift-0.18.0-SNAPSHOT
>                    Writing /Users/rmotamedi/oss/aurora/dist/apache.aurora.thrift-0.18.0-SNAPSHOT.tar.gz
>                    Running packager against /Users/rmotamedi/oss/aurora/dist/apache.thermos.common-0.18.0-SNAPSHOT
>                    Writing /Users/rmotamedi/oss/aurora/dist/apache.thermos.common-0.18.0-SNAPSHOT.tar.gz
>                    Running packager against /Users/rmotamedi/oss/aurora/dist/apache.thermos.config-0.18.0-SNAPSHOT
>                    Writing /Users/rmotamedi/oss/aurora/dist/apache.thermos.config-0.18.0-SNAPSHOT.tar.gz
>                    Running packager against /Users/rmotamedi/oss/aurora/dist/apache.aurora.common-0.18.0-SNAPSHOT
>                    Writing /Users/rmotamedi/oss/aurora/dist/apache.aurora.common-0.18.0-SNAPSHOT.tar.gz
>                    Running packager against /Users/rmotamedi/oss/aurora/dist/apache.aurora.config-0.18.0-SNAPSHOT
>                    Writing /Users/rmotamedi/oss/aurora/dist/apache.aurora.config-0.18.0-SNAPSHOT.tar.gz
>                    Running packager against /Users/rmotamedi/oss/aurora/dist/apache.aurora.client-0.18.0-SNAPSHOT
>                    Writing /Users/rmotamedi/oss/aurora/dist/apache.aurora.client-0.18.0-SNAPSHOT.tar.gz
>                    Running packager against /Users/rmotamedi/oss/aurora/dist/apache.aurora.admin-0.18.0-SNAPSHOT
>                    Writing /Users/rmotamedi/oss/aurora/dist/apache.aurora.admin-0.18.0-SNAPSHOT.tar.gz
>                    Running packager against /Users/rmotamedi/oss/aurora/dist/apache.aurora.kerberos-0.18.0-SNAPSHOT
>                    Writing /Users/rmotamedi/oss/aurora/dist/apache.aurora.kerberos-0.18.0-SNAPSHOT.tar.gz
> 16:22:23 00:07   [complete]
>                SUCCESS
> ```
> 
> 
> Thanks,
> 
> Reza Motamedi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message