aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Review Request 58609: Switch Thermos runner to simple disk log layout
Date Fri, 21 Apr 2017 09:35:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58609/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen and Zameer Manji.


Repository: aurora


Description
-------

Switch Thermos runner to simple disk log layout.

This collapses the individual files per loglevel. We will therefore have just one log file
for executor and one for the runner.

-- 

Not to reviwers: I am unsure why the executor log file defaults to __main__ rather than the
name of the binary. I decided not to dig deeper here, as it is not my main problem during
operations.


Diffs
-----

  src/main/python/apache/aurora/executor/thermos_task_runner.py 8f88af4c24ddc603fa12587741af56a6c711e420



Diff: https://reviews.apache.org/r/58609/diff/1/


Testing
-------

./pants test.pytest src/test/python::


File Attachments
----------------

after.png
  https://reviews.apache.org/media/uploaded/files/2017/04/21/8816f094-b473-45bd-8d9a-fd2f3fad7dfe__after.png
before.png
  https://reviews.apache.org/media/uploaded/files/2017/04/21/f10b3500-a66b-4850-a571-f964b97b7b40__before.png


Thanks,

Stephan Erb


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message