aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 58366: Allow resource monitors to be disabled.
Date Tue, 18 Apr 2017 16:45:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58366/#review172221
-----------------------------------------------------------



I have always assumed at least Twitter can leverage those metrics. If this is not the case,
I would love if we just drop the accounting within Thermos completely. We also have https://issues.apache.org/jira/browse/AURORA-1033
to track this.

- Stephan Erb


On April 12, 2017, 10:08 p.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58366/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 10:08 p.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb.
> 
> 
> Bugs: AURORA-1918
>     https://issues.apache.org/jira/browse/AURORA-1918
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow resource monitors to be disabled.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c6c08983fb2d204afedd419798135d667169bce4

>   src/main/python/apache/thermos/monitoring/resource.py 434666696e600a0e6c19edd986c86575539976f2

>   src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py 38deae69dce7d88dab87f70e0128e0b86091fdef

> 
> 
> Diff: https://reviews.apache.org/r/58366/diff/3/
> 
> 
> Testing
> -------
> 
> Tested -thermos_executor_flags="--task_disk_collection_interval_secs=0 --task_process_collection_interval_secs=0"
(and different combinations: disk enabled and process disabled, disk disabled and process
enabled, both enabled, both disabled). Launched various jobs and ensured the specific resource
monitors were enabled or disabled as per the executor flags.
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message