aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santhosh Kumar Shanmugham <santhoshkuma...@gmail.com>
Subject Re: Review Request 58462: Fix bug. Do not increase current_consecutive_successes if .healthchecksnooze present
Date Fri, 14 Apr 2017 21:26:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58462/#review172032
-----------------------------------------------------------




src/main/python/apache/aurora/executor/common/health_checker.py
Lines 163-166 (patched)
<https://reviews.apache.org/r/58462/#comment245092>

    This will cause a task to get stuck in `STARTING` since `self.running` will never be set
to `True`.
    
    Can you explain the particular usecase here? Also add a test case to exercise this branch.


- Santhosh Kumar Shanmugham


On April 14, 2017, 1:35 p.m., Vladimir Khalatyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58462/
> -----------------------------------------------------------
> 
> (Updated April 14, 2017, 1:35 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix bug. Do not increase current_consecutive_successes if .healthchecksnooze present
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py e9e4129af2db5202a82e9f6d54109a00bbae97ce

> 
> 
> Diff: https://reviews.apache.org/r/58462/diff/1/
> 
> 
> Testing
> -------
> 
> The Health Check is succeeding when the .healthchecksnooze is present. But it should
just snooze which means there shouldn't be any increase in consecutive successes or consecutive
failures.
> 
> 
> Thanks,
> 
> Vladimir Khalatyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message