aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Robinson <drobin...@twopensource.com>
Subject Re: Review Request 58366: Allow resource monitors to be disabled.
Date Tue, 11 Apr 2017 20:50:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58366/
-----------------------------------------------------------

(Updated April 11, 2017, 8:50 p.m.)


Review request for Aurora.


Changes
-------

Fixed broken test.


Bugs: AURORA-1918
    https://issues.apache.org/jira/browse/AURORA-1918


Repository: aurora


Description
-------

Allow resource monitors to be disabled.


Diffs (updated)
-----

  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c6c08983fb2d204afedd419798135d667169bce4

  src/main/python/apache/thermos/monitoring/resource.py 434666696e600a0e6c19edd986c86575539976f2

  src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py 38deae69dce7d88dab87f70e0128e0b86091fdef



Diff: https://reviews.apache.org/r/58366/diff/2/

Changes: https://reviews.apache.org/r/58366/diff/1-2/


Testing
-------

Tested -thermos_executor_flags="--task_disk_collection_interval_secs=0 --task_process_collection_interval_secs=0"
(and different combinations: disk enabled and process disabled, disk disabled and process
enabled, both enabled, both disabled). Launched various jobs and ensured the specific resource
monitors were enabled or disabled as per the executor flags.


Thanks,

David Robinson


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message