aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 58066: Fix schema to allow multiple task volumes per task.
Date Thu, 06 Apr 2017 13:45:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58066/#review171203
-----------------------------------------------------------


Ship it!




Master (656cf9a) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 6, 2017, 1:29 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58066/
> -----------------------------------------------------------
> 
> (Updated April 6, 2017, 1:29 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1914
>     https://issues.apache.org/jira/browse/AURORA-1914
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The original commit adding this feature added an artifical constraint to the schema that
prevented more than one task volume per task. This is because there was a `UNIQUE` constraint
between the volumes table and the task config table, preventing a task config from being associated
with more than one volume.
> 
> This patch removes that constraint. As a result some of the MyBatis mappers had to change
and a new migration was added.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/migration/V010_RemoveUniqueConstraint.java
PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java 6a36e276d85de7b463ff92e53f66e736c0823696

>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java cf65a28c4eb89e8de77734c93b26bc7234b4f927

>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml 97f6b80fa02ffb73671cf3c8b2aec32fe93a2030

>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql ff1623acddf2ca2d59b5f987955005fe1e5d2bfd

>   src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 80be33969d697ab7821eb0ef7cb5f7a7cb9ba61f

>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora be43a099109d73b5dc34d8a66d2ca9782e025b0b

> 
> 
> Diff: https://reviews.apache.org/r/58066/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message