aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 57881: Remove use of deprecated fields in tests
Date Mon, 03 Apr 2017 21:50:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57881/#review170934
-----------------------------------------------------------


Ship it!




Ship It!

- Stephan Erb


On March 31, 2017, 8:01 p.m., Nicolás Donatucci wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57881/
> -----------------------------------------------------------
> 
> (Updated March 31, 2017, 8:01 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Bugs: Aurora-1707
>     https://issues.apache.org/jira/browse/Aurora-1707
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removed the usage of numCpus, ramMb and diskMb from tests and replaced them with the
Resource set when necessary. 
> Also modified the thrift backfill so that it won't backfill those resource fields anymore.
> 
> Related Issue: Aurora-1707
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/Tasks.java 3aabc5ef222a97d8ebde693c52030a66bca340d2

>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java ad6b3efb69d71e8915044abafacec85f8c9efc59

>   src/main/java/org/apache/aurora/scheduler/storage/log/ThriftBackfill.java 3567cf07e5864e9d624aea712d56e1b8e0a4bbeb

>   src/main/python/apache/aurora/config/thrift.py 601e1fc18a6deaac1fbe4f7fc6f808d0a52f7ef0

>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
d6904f844df3880fb699948b3a7fd457c9e81ed0 
>   src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
b759427786b3a118a14f8fd7524d86ed7d61dda1 
>   src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 1d7f9f45e7a65838e2c826b4b21a31c7944eab19

>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java f14d971bbedf27510a8d3e277c43408c7e4edcae

>   src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java
02bfc51a7cba1116334dbfe30e0abe05ba3fbb4a 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2e97a3361feaed71e4f39cbd27cf5afb7d919e31

>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61

>   src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java 19c1f8e949e31a2338a5cbbbf15228230377a9f5

>   src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 53329393046076a2cc7151c4af64174d975f477d

>   src/test/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollectorTest.java 3e5296e40ba63dc06a4720f1ff2c1ff046613ea2

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 34c24aac9339e59c435925bd2357ce86998f5f02

>   src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java ca9525665805a33b4a322a72022ff037f0dd2a94

>   src/test/java/org/apache/aurora/scheduler/storage/log/ThriftBackfillTest.java 544c6c256aed92535488cb75e8c2bc364f67c694

>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 04f782935dcf9955b6918ad690d4fdd853ec1e84

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
0ff6ce057e11cb51ca02645bc6abb8f9dd66301e 
>   src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java c78c7fbd7d600586136863c99ce3d7387895efee

>   src/test/python/apache/aurora/config/test_base.py b354f0804ce70682e8ecb9fb3a3d8fe736fd1cc5

>   src/test/python/apache/aurora/config/test_thrift.py 2a6a5d0c371218d5cb1ec872d6e6ba8dff22784c

> 
> 
> Diff: https://reviews.apache.org/r/57881/diff/3/
> 
> 
> Testing
> -------
> 
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Nicolás Donatucci
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message