Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 06788200C4E for ; Wed, 22 Mar 2017 23:50:47 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 051B2160B91; Wed, 22 Mar 2017 22:50:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2DC99160B74 for ; Wed, 22 Mar 2017 23:50:46 +0100 (CET) Received: (qmail 30825 invoked by uid 500); 22 Mar 2017 22:50:45 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 30805 invoked by uid 99); 22 Mar 2017 22:50:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Mar 2017 22:50:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B7185C86D2; Wed, 22 Mar 2017 22:50:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Vr5lFq-9ON2R; Wed, 22 Mar 2017 22:50:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0A8265FCFA; Wed, 22 Mar 2017 22:50:43 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B177BE00C7; Wed, 22 Mar 2017 22:50:38 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A487AC4034D; Wed, 22 Mar 2017 22:50:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1320954334905179796==" MIME-Version: 1.0 Subject: Re: Review Request 57717: Support Mesos Maintenance From: Zameer Manji To: Santhosh Kumar Shanmugham , Stephan Erb Cc: Aurora ReviewBot , Zameer Manji , Aurora Date: Wed, 22 Mar 2017 22:50:38 -0000 Message-ID: <20170322225038.40399.388@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zameer Manji X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57717/ X-Sender: Zameer Manji References: <20170320221025.9563.82360@reviews-vm2.apache.org> In-Reply-To: <20170320221025.9563.82360@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/test/sh/org/apache/aurora/e2e/generate_mesos_maintenance_schedule.py Reply-To: Zameer Manji X-ReviewRequest-Repository: aurora archived-at: Wed, 22 Mar 2017 22:50:47 -0000 --===============1320954334905179796== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57717/ ----------------------------------------------------------- (Updated March 22, 2017, 3:50 p.m.) Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb. Changes ------- Feedback. Bugs: AURORA-1904 https://issues.apache.org/jira/browse/AURORA-1904 Repository: aurora Description ------- This adds support for Mesos Maintenance per the design doc[1]. Per the design the scheduler gains another parameter, `unavailability_threshold`. With this threshold the scheduler does the following: 1. Accept all inverse offers from Mesos. 2. Drain when accepting an inverse offer if the unavailability starts within the thereshold. 3. Veto any offers with unavailability starting within the threshold. 4. Penalize offers that have unavailablity information For readability and safety the time based code uses the new `java.time` package in Java 8, primarily relying on the `Instant` class. [1]: https://docs.google.com/document/d/1Z7dFAm6I1nrBE9S5WHw0D0LApBumkIbHrk0-ceoD2YI/edit#heading=h.n5tvzjaj9llx Diffs (updated) ----- commons/src/main/java/org/apache/aurora/common/util/Clock.java 5c4ced1ffe7827c0e529d17cb51db42fd1b762ff commons/src/main/java/org/apache/aurora/common/util/testing/FakeClock.java 104f2c64196da16d68a85e365f1dc762547e1e36 examples/vagrant/upstart/aurora-scheduler.conf 31fa0368435a179698d1a745331a85430049762e src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java 45f59c0bd09f81916c95345233e6642b4cf81830 src/main/java/org/apache/aurora/scheduler/HostOffer.java 23f0600d64e1e15f4856f397e839e3d1c87f3b96 src/main/java/org/apache/aurora/scheduler/base/Conversions.java 8295216dc651eff357c4f3c51c8a53052244c6bf src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14 src/main/java/org/apache/aurora/scheduler/mesos/Driver.java 71547ce931e0161adfc5de43f367b3ec43aa17e8 src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java 801551bce7879989d93d2d32a8fe28a891312c73 src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java 4a604f595c07b0cb929d3ffffa5d2b6b18256f45 src/main/java/org/apache/aurora/scheduler/mesos/VersionedMesosSchedulerImpl.java a519c7dfe95baf346d3cb6975351318c7cbff4af src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java f1326eaa88aa75d7d8dd176e6e7fe750fa145347 src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35 src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java ba49e7a4ccfaddbd85218018b0bbad5efab41d99 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 574efc9e44a21fc7cdc0d316d6c51f47cd673ce3 src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java da378e84ee65a658ff2382489d3ab6d5f6451b5f src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 1d7f9f45e7a65838e2c826b4b21a31c7944eab19 src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java 80f631e9024e266fe823d845193b19c1d559a5ef src/test/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverServiceTest.java a6c28bbd9616bfa3d454fbd66e09f88185f39613 src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 02bfc51a7cba1116334dbfe30e0abe05ba3fbb4a src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java ae83dea05e10ebab0c0b07d60386d0faf78fb7e9 src/test/sh/org/apache/aurora/e2e/generate_mesos_maintenance_schedule.py PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example.aurora de8179228d9359900eadf4084355ea257bea45ba src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 80b4c54774a02fdc2ee0e36d26f81aedd2e0055e Diff: https://reviews.apache.org/r/57717/diff/4/ Changes: https://reviews.apache.org/r/57717/diff/3-4/ Testing ------- e2e tests Thanks, Zameer Manji --===============1320954334905179796==--