Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============4312035257009296416=="
MIME-Version: 1.0
Subject: Re: Review Request 57757: Make Thermos observer resource collection
 intervals configurable
From: Aurora ReviewBot <wfarner@apache.org>
To: Santhosh Kumar Shanmugham <santhoshkumar.s@gmail.com>,
 Zameer Manji <zmanji@apache.org>
Cc: Aurora ReviewBot <wfarner@apache.org>, Stephan Erb <serb@apache.org>,
 Aurora <reviews@aurora.apache.org>
Date: Mon, 20 Mar 2017 22:48:57 -0000
Message-ID: <20170320224857.9562.90564@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Aurora ReviewBot <noreply@reviews.apache.org>
References: <20170320223628.9562.70066@reviews-vm2.apache.org>
In-Reply-To: <20170320223628.9562.70066@reviews-vm2.apache.org>
Reply-To: Aurora ReviewBot <wfarner@apache.org>
archived-at: Mon, 20 Mar 2017 22:49:08 -0000

--===============4312035257009296416==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57757/#review169516
-----------------------------------------------------------


Master (b8f72d1) is red with this patch.
  ./build-support/jenkins/build.sh

  Test coverage missing for org/apache/aurora/scheduler/events/WebhookInfo
  Test coverage missing for org/apache/aurora/scheduler/storage/log/WriteAheadStorageForwarder
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$1
  Test coverage missing for org/apache/aurora/scheduler/storage/log/StreamManagerImpl$StreamTransactionImpl
  Test coverage missing for org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl$1
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$Settings
  Test coverage missing for org/apache/aurora/scheduler/storage/log/StreamManagerImpl
  Test coverage missing for org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorageModule
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage
  Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotDeduplicator$SnapshotDeduplicatorImpl
  Test coverage missing for org/apache/aurora/scheduler/storage/log/Entries
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogManager
  Test coverage missing for org/apache/aurora/scheduler/storage/backup/StorageBackup$StorageBackupImpl$BackupConfig
  Test coverage missing for org/apache/aurora/scheduler/storage/backup/BackupModule
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$7
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$6
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$5
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$4
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$3
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$2
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$1
  Test coverage missing for org/apache/aurora/scheduler/TaskVars
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$SchedulerCandidateImpl
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
  Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig
  Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter
  Test coverage missing for org/apache/aurora/scheduler/TaskVars$1
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle
  Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler
  Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/MaintenanceModeTypeHandler

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================

BUILD FAILED

Total time: 7 mins 47.963 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 21, 2017, 12:36 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57757/
> -----------------------------------------------------------
> 
> (Updated March 21, 2017, 12:36 a.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham and Zameer Manji.
> 
> 
> Bugs: AURORA-1907
>     https://issues.apache.org/jira/browse/AURORA-1907
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We have noticed that on hosts with lots of active tasks (~100) the observer UI
> is not usable. Thermos fully utilizes one core but does not render any requests.
> 
> Dumping `/threads` indicates the observer might be backlogged by the hundred
> concurrent `TaskResourceMonitor` threads. Due to the Python GIL only one can
> make progress at a time though.
> 
> This patch is now adding options to control the resource collection interval,
> giving operators a possibility to reduce the CPU pressure.
> 
> -- 
> 
> Reviewer notes: I dropped the entrypoint test as it was heavily relying on mocks
> without significant code coverage.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md d58d2bd2558c2060aa659402ea88271bd8704cde 
>   docs/README.md 1d679e27cf26122c34a9157194f189ce3035b176 
>   docs/reference/observer-configuration.md PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos_observer.py 4bba01930434f33150b0413d20d9657b61b364c5 
>   src/main/python/apache/thermos/monitoring/resource.py 53d0ff1a71c27f053c59acca556c35d1e5ac91f0 
>   src/main/python/apache/thermos/observer/task_observer.py 1485de8faef52716f11b82a3556064de26c67427 
>   src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py e1c8dec5f26be1aec931b1a614ecc138ae63d9de 
> 
> 
> Diff: https://reviews.apache.org/r/57757/diff/4/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/{test,main}/python:: -- -v
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


--===============4312035257009296416==--