Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A0688200C31 for ; Wed, 8 Mar 2017 21:29:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9EEE3160B83; Wed, 8 Mar 2017 20:29:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E5F7B160B73 for ; Wed, 8 Mar 2017 21:29:51 +0100 (CET) Received: (qmail 96552 invoked by uid 500); 8 Mar 2017 20:29:51 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 96541 invoked by uid 99); 8 Mar 2017 20:29:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Mar 2017 20:29:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3F1471A04FE for ; Wed, 8 Mar 2017 20:29:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ZBIpslO3I8-Q for ; Wed, 8 Mar 2017 20:29:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 193E95F27E for ; Wed, 8 Mar 2017 20:29:49 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E8F53E0041; Wed, 8 Mar 2017 20:29:40 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B8677C408F4; Wed, 8 Mar 2017 20:29:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1584295290216712525==" MIME-Version: 1.0 Subject: Re: Review Request 57404: Reduce log output in `VersionedSchedulerDriverService`. From: Zameer Manji To: Stephan Erb Cc: Aurora , Zameer Manji Date: Wed, 08 Mar 2017 20:29:40 -0000 Message-ID: <20170308202940.27242.99253@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zameer Manji X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57404/ X-Sender: Zameer Manji References: <20170308020556.19287.70199@reviews-vm2.apache.org> In-Reply-To: <20170308020556.19287.70199@reviews-vm2.apache.org> Reply-To: Zameer Manji X-ReviewRequest-Repository: aurora archived-at: Wed, 08 Mar 2017 20:29:52 -0000 --===============1584295290216712525== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57404/#review168331 ----------------------------------------------------------- @ReviewBot retry - Zameer Manji On March 7, 2017, 6:05 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57404/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 6:05 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > The `acceptOffers` log message outputs the entire `Operation` object which for > the `LAUNCH` type includes the entire `TaskInfo` protobuf. This makes the log output > massive. This reduces the logging to just the type of the operation. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java 9f39aeb1106d5ec29949280b5cf1fe3413e055d4 > > > Diff: https://reviews.apache.org/r/57404/diff/2/ > > > Testing > ------- > > > Thanks, > > Zameer Manji > > --===============1584295290216712525==--