aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 58066: Fix schema to allow multiple task volumes per task.
Date Thu, 30 Mar 2017 14:49:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58066/#review170579
-----------------------------------------------------------



LGTM to me in general.


src/main/java/org/apache/aurora/scheduler/storage/db/migration/V010_RemoveUniqueConstraint.java
Lines 33-34 (patched)
<https://reviews.apache.org/r/58066/#comment243436>

    Where would I find this name? Searching the code base for `CONSTRAINT_654B` does not return
anything for mre.



src/main/java/org/apache/aurora/scheduler/storage/db/migration/V010_RemoveUniqueConstraint.java
Lines 38-40 (patched)
<https://reviews.apache.org/r/58066/#comment243435>

    Assuming we perform:
    
    * up-grade
    * down-grade
    * up-grade
    
    We could end up with a different constraint name that will not be dropped properly. We
should make sure the name is of the constraint is always consistently added during downgrades.



src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java
Lines 89-93 (patched)
<https://reviews.apache.org/r/58066/#comment243437>

    It feeld weird to me that we are checkin for `image` when deciding if we should fill the
(from a datastructure perspective) unrelated field `volumes`. 
    
    Would it be incorrect that we always populate the volumes?


- Stephan Erb


On March 30, 2017, 5:26 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58066/
> -----------------------------------------------------------
> 
> (Updated March 30, 2017, 5:26 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1914
>     https://issues.apache.org/jira/browse/AURORA-1914
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The original commit adding this feature added an artifical constraint to the schema that
prevented more than one task volume per task. This is because there was a `UNIQUE` constraint
between the volumes table and the task config table, preventing a task config from being associated
with more than one volume.
> 
> This patch removes that constraint. As a result some of the MyBatis mappers had to change
and a new migration was added.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/migration/V010_RemoveUniqueConstraint.java
PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java 6a36e276d85de7b463ff92e53f66e736c0823696

>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java cf65a28c4eb89e8de77734c93b26bc7234b4f927

>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml 97f6b80fa02ffb73671cf3c8b2aec32fe93a2030

>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql ff1623acddf2ca2d59b5f987955005fe1e5d2bfd

>   src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 80be33969d697ab7821eb0ef7cb5f7a7cb9ba61f

>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora be43a099109d73b5dc34d8a66d2ca9782e025b0b

> 
> 
> Diff: https://reviews.apache.org/r/58066/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message