aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 58054: Sort the set objects inside TaskConfig during Job diff.
Date Thu, 30 Mar 2017 05:14:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58054/#review170529
-----------------------------------------------------------


Ship it!




Master (3a9aabd) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 30, 2017, 4:55 a.m., Santhosh Kumar Shanmugham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58054/
> -----------------------------------------------------------
> 
> (Updated March 30, 2017, 4:55 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1913
>     https://issues.apache.org/jira/browse/AURORA-1913
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Sort the entires in `set` fields inside `TaskConfig` as strings before
> shelling out to diff so that the output is consistent and meaningful.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/diff_formatter.py a1b9bb3086b277e5da6d21496879a7aca8299e00

>   src/test/python/apache/aurora/client/cli/test_diff_formatter.py a145d8846f65ba222d7fd3f91bf9109a50f26314

>   src/test/python/apache/aurora/client/cli/util.py c65ae75c680ec4ca4e4d2a398c80e73ddff16649

> 
> 
> Diff: https://reviews.apache.org/r/58054/diff/2/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message