aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santhosh Kumar Shanmugham <santhoshkuma...@gmail.com>
Subject Re: Review Request 58054: Sort the set objects inside TaskConfig during Job diff.
Date Thu, 30 Mar 2017 04:55:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58054/
-----------------------------------------------------------

(Updated March 29, 2017, 9:55 p.m.)


Review request for Aurora and Zameer Manji.


Changes
-------

Style fixes, feedback.


Bugs: AURORA-1913
    https://issues.apache.org/jira/browse/AURORA-1913


Repository: aurora


Description
-------

Sort the entires in `set` fields inside `TaskConfig` as strings before
shelling out to diff so that the output is consistent and meaningful.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/diff_formatter.py a1b9bb3086b277e5da6d21496879a7aca8299e00

  src/test/python/apache/aurora/client/cli/test_diff_formatter.py a145d8846f65ba222d7fd3f91bf9109a50f26314

  src/test/python/apache/aurora/client/cli/util.py c65ae75c680ec4ca4e4d2a398c80e73ddff16649



Diff: https://reviews.apache.org/r/58054/diff/2/

Changes: https://reviews.apache.org/r/58054/diff/1-2/


Testing
-------

./build-support/jenkins/build.sh


Thanks,

Santhosh Kumar Shanmugham


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message